Re: [PATCH] remove drivers/fc4/

Re: [PATCH] remove drivers/fc4/

[David S. Miller]

From: Christoph Hellwig <hch@lst.de>
Subject: [PATCH] remove drivers/fc4/
Date: Sun, 19 Jun 2005 13:37:24 +0200

> This code doesn't work since 2.2.x times, uses various obsolete APIs,
> pokes into the midlayer code where it shouldn't and thus won't even
> have a chance to compile after my next round of patches.
> 
> Let's get rid of it, anyone who wants to resurrect it can find it
> in the archives, and it'll require a major rewrite anyway.

It does work for some people.  People do use it.

It built just fine before changes started going in
lately.  Removing it is not a magic escape hatch you
get to use because you want to change some interfaces
but don't know how to do so without breaking the
driver.

Re: [PATCH] remove drivers/fc4/

[Christoph Hellwig]

On Sun, Jun 19, 2005 at 12:57:47PM -0700, David S. Miller wrote:
> From: Christoph Hellwig <hch@lst.de>
> Subject: [PATCH] remove drivers/fc4/
> Date: Sun, 19 Jun 2005 13:37:24 +0200
> 
> > This code doesn't work since 2.2.x times, uses various obsolete APIs,
> > pokes into the midlayer code where it shouldn't and thus won't even
> > have a chance to compile after my next round of patches.
> > 
> > Let's get rid of it, anyone who wants to resurrect it can find it
> > in the archives, and it'll require a major rewrite anyway.
> 
> It does work for some people.  People do use it.

Who?  looking at sparclinux doesn't show anyone who got it working
since 2.2.x days.

> It built just fine before changes started going in
> lately.  Removing it is not a magic escape hatch you
> get to use because you want to change some interfaces
> but don't know how to do so without breaking the
> driver.

It's doing completely stupid things about poking into EH internals.
This never was an API and no other driver does this - and I'm not
going to do anything but if 0'ing large parts of the drivers to
'fix' the build because there's very little that wasn't totally
broken before.

Note that you actually agreed on removing them from the tree back
in June 2004.

Re: [PATCH] remove drivers/fc4/

[David S. Miller]

From: Christoph Hellwig <hch@lst.de>
Date: Sun, 19 Jun 2005 22:40:08 +0200

> Note that you actually agreed on removing them from the tree back
> in June 2004.

Currently, I'm giving Ben Collins a little bit more time
to try and get his setup working.

If you really want to kill the driver, feel free.

Re: [PATCH] remove drivers/fc4/

[Al Viro]

On Sun, Jun 19, 2005 at 10:40:08PM +0200, Christoph Hellwig wrote:
> On Sun, Jun 19, 2005 at 12:57:47PM -0700, David S. Miller wrote:
> > From: Christoph Hellwig <hch@lst.de>
> > Subject: [PATCH] remove drivers/fc4/
> > Date: Sun, 19 Jun 2005 13:37:24 +0200
> > 
> > > This code doesn't work since 2.2.x times, uses various obsolete APIs,
> > > pokes into the midlayer code where it shouldn't and thus won't even
> > > have a chance to compile after my next round of patches.
> > > 
> > > Let's get rid of it, anyone who wants to resurrect it can find it
> > > in the archives, and it'll require a major rewrite anyway.
> > 
> > It does work for some people.  People do use it.
> 
> Who?  looking at sparclinux doesn't show anyone who got it working
> since 2.2.x days.

Umm...  sparc64 does work with 2.6.  I don't have any fiberchannel
hardware in question, but both 2.4 and 2.6 work on Ultra just fine.
Ought to try and resurrect the quad-SS20 box and see what's the
situation with sparc32 one of these days...

Re: [PATCH] remove drivers/fc4/

[Christoph Hellwig]

On Sun, Jun 19, 2005 at 10:23:38PM +0100, Al Viro wrote:
> > Who?  looking at sparclinux doesn't show anyone who got it working
> > since 2.2.x days.
> 
> Umm...  sparc64 does work with 2.6.  I don't have any fiberchannel
> hardware in question, but both 2.4 and 2.6 work on Ultra just fine.
> Ought to try and resurrect the quad-SS20 box and see what's the
> situation with sparc32 one of these days...

Huh?  'sparclinux' in this contect is the sparclinux mainlinglist, and
'it' refers to drivers/fc4