From: Jens Axboe <axboe@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: jejb@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH, scsi-block-2.6] don't export bio_map_kern
Date: Mon, 20 Jun 2005 12:37:51 +0200 [thread overview]
Message-ID: <20050620103750.GB15021@suse.de> (raw)
In-Reply-To: <20050619093113.GB16872@lst.de>
On Sun, Jun 19 2005, Christoph Hellwig wrote:
> Modules should use the higher-level blk_rq_map_kern, which they
> currently do anyway.
>
>
> Index: linux-2.6/fs/bio.c
> ===================================================================
> --- linux-2.6.orig/fs/bio.c 2005-06-18 17:26:42.000000000 +0200
> +++ linux-2.6/fs/bio.c 2005-06-18 17:49:31.000000000 +0200
> @@ -1201,7 +1201,6 @@
> EXPORT_SYMBOL(bio_add_page);
> EXPORT_SYMBOL(bio_get_nr_vecs);
> EXPORT_SYMBOL(bio_unmap_user);
> -EXPORT_SYMBOL(bio_map_kern);
> EXPORT_SYMBOL(bio_pair_release);
> EXPORT_SYMBOL(bio_split);
> EXPORT_SYMBOL(bio_split_pool);
Why? It would be perfectly legit for stacking driver to set up their own
bio with kernel mapped data. As with bio_map_user(), blk_rq_map_kern
isn't the only valid user of bio_map_kern().
--
Jens Axboe
prev parent reply other threads:[~2005-06-20 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-19 9:31 [PATCH, scsi-block-2.6] don't export bio_map_kern Christoph Hellwig
2005-06-20 10:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050620103750.GB15021@suse.de \
--to=axboe@suse.de \
--cc=hch@lst.de \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox