* [PATCH, scsi-block-2.6] don't export bio_map_kern
@ 2005-06-19 9:31 Christoph Hellwig
2005-06-20 10:37 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2005-06-19 9:31 UTC (permalink / raw)
To: axboe, jejb; +Cc: linux-scsi
Modules should use the higher-level blk_rq_map_kern, which they
currently do anyway.
Index: linux-2.6/fs/bio.c
===================================================================
--- linux-2.6.orig/fs/bio.c 2005-06-18 17:26:42.000000000 +0200
+++ linux-2.6/fs/bio.c 2005-06-18 17:49:31.000000000 +0200
@@ -1201,7 +1201,6 @@
EXPORT_SYMBOL(bio_add_page);
EXPORT_SYMBOL(bio_get_nr_vecs);
EXPORT_SYMBOL(bio_unmap_user);
-EXPORT_SYMBOL(bio_map_kern);
EXPORT_SYMBOL(bio_pair_release);
EXPORT_SYMBOL(bio_split);
EXPORT_SYMBOL(bio_split_pool);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH, scsi-block-2.6] don't export bio_map_kern
2005-06-19 9:31 [PATCH, scsi-block-2.6] don't export bio_map_kern Christoph Hellwig
@ 2005-06-20 10:37 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2005-06-20 10:37 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: jejb, linux-scsi
On Sun, Jun 19 2005, Christoph Hellwig wrote:
> Modules should use the higher-level blk_rq_map_kern, which they
> currently do anyway.
>
>
> Index: linux-2.6/fs/bio.c
> ===================================================================
> --- linux-2.6.orig/fs/bio.c 2005-06-18 17:26:42.000000000 +0200
> +++ linux-2.6/fs/bio.c 2005-06-18 17:49:31.000000000 +0200
> @@ -1201,7 +1201,6 @@
> EXPORT_SYMBOL(bio_add_page);
> EXPORT_SYMBOL(bio_get_nr_vecs);
> EXPORT_SYMBOL(bio_unmap_user);
> -EXPORT_SYMBOL(bio_map_kern);
> EXPORT_SYMBOL(bio_pair_release);
> EXPORT_SYMBOL(bio_split);
> EXPORT_SYMBOL(bio_split_pool);
Why? It would be perfectly legit for stacking driver to set up their own
bio with kernel mapped data. As with bio_map_user(), blk_rq_map_kern
isn't the only valid user of bio_map_kern().
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-06-20 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-19 9:31 [PATCH, scsi-block-2.6] don't export bio_map_kern Christoph Hellwig
2005-06-20 10:37 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox