public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: jejb@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH, scsi-block-2.6] ll_rw_blk.c kerneldoc fixups
Date: Mon, 20 Jun 2005 12:53:42 +0200	[thread overview]
Message-ID: <20050620105342.GE15021@suse.de> (raw)
In-Reply-To: <20050620104035.GA4246@lst.de>

On Mon, Jun 20 2005, Christoph Hellwig wrote:
> On Mon, Jun 20, 2005 at 12:40:44PM +0200, Jens Axboe wrote:
> > On Sun, Jun 19 2005, Christoph Hellwig wrote:
> > > @@ -2098,14 +2098,14 @@
> > >   *    Data will be mapped directly for zero copy io, if possible. Otherwise
> > >   *    a kernel bounce buffer is used.
> > >   *
> > > - *    A matching blk_rq_unmap_user() must be issued at the end of io, while
> > > - *    still in process context.
> > > + *    A matching blk_rq_unmap_user_iov() must be issued at the end of io,
> > > + *    while still in process context.
> > 
> > ?
> 
> This is ontop of my patch to remove the non-iov variant.

Hmm, the function names still looked like the older ones.

> > > @@ -2221,9 +2220,10 @@
> > >  /**
> > >   * blk_rq_map_kern - map kernel data to a request, for REQ_BLOCK_PC usage
> > >   * @q:		request queue where request should be inserted
> > > - * @rw:		READ or WRITE data
> > > + * @rw:		request to fill
> > 
> > @rq
> > 
> > Rest looks good, care to rediff it?
> 
> Yeah, will do so later.

Thanks!

-- 
Jens Axboe


  reply	other threads:[~2005-06-20 10:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-19  9:32 [PATCH, scsi-block-2.6] ll_rw_blk.c kerneldoc fixups Christoph Hellwig
2005-06-20 10:40 ` Jens Axboe
2005-06-20 10:40   ` Christoph Hellwig
2005-06-20 10:53     ` Jens Axboe [this message]
2005-06-20 12:24 ` Jens Axboe
2005-06-20 12:38   ` Christoph Hellwig
2005-06-21 14:41     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050620105342.GE15021@suse.de \
    --to=axboe@suse.de \
    --cc=hch@lst.de \
    --cc=jejb@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox