From: Christoph Hellwig <hch@lst.de>
To: markus.lidel@shadowconnect.com
Cc: linux-scsi@vger.kernel.org
Subject: odd sg_request munging code in i2o post-2.6.12
Date: Mon, 27 Jun 2005 22:55:20 +0200 [thread overview]
Message-ID: <20050627205520.GA20272@lst.de> (raw)
Markus, any chance you could try to send in changes that deal with
scsi internals through James SCSI tree?
You've sent some changes in that are rather odd:
- created a include/scsi/sg_request.h header that duplicates
struct sg_request, an internal data structure of the sg driver.
This approach gets easily out of sync.
- and poke into this data structure of an upper layer driver from a LLDD.
That's a big "DON'T" While of the current drivers only SG uses that
field it's open to any ULD, and you're also not supporting SG_IO on
non-sg devices.
Besides that we are actively killing scsi_requests before 2.6.13,
so you code will have to be remove by then.
reply other threads:[~2005-06-27 20:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050627205520.GA20272@lst.de \
--to=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=markus.lidel@shadowconnect.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox