* odd sg_request munging code in i2o post-2.6.12
@ 2005-06-27 20:55 Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2005-06-27 20:55 UTC (permalink / raw)
To: markus.lidel; +Cc: linux-scsi
Markus, any chance you could try to send in changes that deal with
scsi internals through James SCSI tree?
You've sent some changes in that are rather odd:
- created a include/scsi/sg_request.h header that duplicates
struct sg_request, an internal data structure of the sg driver.
This approach gets easily out of sync.
- and poke into this data structure of an upper layer driver from a LLDD.
That's a big "DON'T" While of the current drivers only SG uses that
field it's open to any ULD, and you're also not supporting SG_IO on
non-sg devices.
Besides that we are actively killing scsi_requests before 2.6.13,
so you code will have to be remove by then.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-06-27 20:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-27 20:55 odd sg_request munging code in i2o post-2.6.12 Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox