public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andrew Morton <akpm@osdl.org>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>,
	aradford@amcc.com, Nick Orlov <bugfixer@list.ru>
Subject: Re: Fw: 2.6.12-mm2: 3ware SATA RAID inaccessible
Date: Tue, 28 Jun 2005 10:25:11 +0200	[thread overview]
Message-ID: <20050628082509.GA4410@suse.de> (raw)
In-Reply-To: <1119829031.5038.15.camel@mulgrave>

On Sun, Jun 26 2005, James Bottomley wrote:
> +static void tw_unmap_internal(TW_Device_Extension *tw_dev, int request_id)
> +{
> +	struct scsi_cmnd *cmd = tw_dev->srb[request_id];
> +
> +	if (cmd->use_sg) {
> +		struct scatterlist *sg;
> +
> +		sg = (struct scatterlist *)cmd->request_buffer;
> +		kunmap_atomic(sg->page, KM_USER0);

Woops. You have to pass the mapped buffer back in, kunmap_atomic() takes
the returned buffer from kmap_atomic() not the page mapped. Silly yes,
but that is how it is...


-- 
Jens Axboe


      parent reply	other threads:[~2005-06-28  8:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-26 22:39 Fw: 2.6.12-mm2: 3ware SATA RAID inaccessible Andrew Morton
2005-06-26 23:37 ` James Bottomley
2005-06-27  4:46   ` Nick Orlov
2005-06-27 14:22     ` James Bottomley
2005-06-28  2:08       ` Nick Orlov
2005-06-28  4:05         ` James Bottomley
2005-06-28 11:02           ` Nick Orlov
2005-06-28 12:09             ` Jens Axboe
2005-06-28 14:18               ` James Bottomley
2005-06-28 14:23                 ` Jens Axboe
2005-06-29  1:58                   ` Nick Orlov
2005-06-27  7:52   ` Jens Axboe
2005-06-27 14:22     ` James Bottomley
2005-06-27 14:27       ` Jens Axboe
2005-06-28  8:25   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050628082509.GA4410@suse.de \
    --to=axboe@suse.de \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=aradford@amcc.com \
    --cc=bugfixer@list.ru \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox