From: Ben Collins <bcollins@debian.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
linux1394-devel@lists.sourceforge.net
Subject: Re: changes to ieee1394/sbp2 outside of linux1394.org
Date: Sat, 9 Jul 2005 13:49:58 -0400 [thread overview]
Message-ID: <20050709174958.GA29099@phunnypharm.org> (raw)
In-Reply-To: <1120926901.5008.12.camel@mulgrave>
On Sat, Jul 09, 2005 at 11:35:01AM -0500, James Bottomley wrote:
> On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote:
> > THese changes break sbp2, and we'll need to revert them in the main stream
> > kernel until the patch is tested and fixed in our tree.
>
> They cannot be simply reverted. The API has changed from the EH
> routines being called with the host lock held to being called lockless.
> If you need the lock, you have to take it yourself, which is what the
> changes do from my reading of the code.
It's not the lock change that is breaking things, it's the RBC changes.
SBP2 simply doesn't work (incorrect information read from the driver,
which I assume is bad translation of the scsi commands caused by the
changes).
--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
SwissDisk - http://www.swissdisk.com/
next prev parent reply other threads:[~2005-07-09 17:49 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-09 12:37 changes to ieee1394/sbp2 outside of linux1394.org Stefan Richter
2005-07-09 15:18 ` James Bottomley
2005-07-09 16:27 ` Ben Collins
2005-07-09 16:35 ` James Bottomley
2005-07-09 16:56 ` Stefan Richter
2005-07-09 17:24 ` James Bottomley
2005-07-15 0:53 ` Rogério Brito
2005-07-15 1:43 ` Ben Collins
2005-07-15 6:36 ` Stefan Richter
2005-07-15 15:30 ` Rogério Brito
2005-07-15 15:15 ` Rogério Brito
2005-07-15 15:53 ` Rogério Brito
2005-07-15 17:28 ` Ben Collins
2005-07-15 18:50 ` Rogério Brito
2005-07-15 20:57 ` Ben Collins
2005-07-15 21:44 ` Stefan Richter
2005-07-16 2:10 ` Rogério Brito
2005-07-16 1:42 ` Rogério Brito
2005-07-16 15:56 ` Ben Collins
2005-07-16 16:42 ` Rogério Brito
2005-07-16 18:10 ` Stefan Richter
2005-07-16 19:34 ` Rogério Brito
2005-07-17 16:57 ` Ben Collins
2005-07-17 19:18 ` Rogério Brito
2005-07-17 19:46 ` Stefan Richter
2005-07-18 0:14 ` Rogério Brito
2005-07-17 23:27 ` Stefan Richter
2005-07-18 4:50 ` Philipp Slusallek
2005-07-18 7:13 ` Stefan Richter
2005-07-18 8:18 ` Rogério Brito
2005-07-20 0:20 ` Rogério Brito
2005-07-09 17:49 ` Ben Collins [this message]
2005-07-09 18:41 ` James Bottomley
2005-07-09 19:22 ` Ben Collins
2005-07-09 16:37 ` Arjan van de Ven
2005-07-09 17:53 ` Ben Collins
2005-07-09 17:00 ` Stefan Richter
2005-07-09 17:51 ` Ben Collins
2005-07-09 17:57 ` Arjan van de Ven
2005-07-09 18:12 ` Ben Collins
2005-07-09 18:38 ` James Bottomley
2005-07-09 23:06 ` Ben Collins
2005-07-10 3:34 ` Jeff Garzik
2005-07-10 4:36 ` Ben Collins
2005-07-10 15:25 ` James Bottomley
2005-07-10 15:58 ` Ben Collins
2005-07-10 17:05 ` James Bottomley
2005-07-10 17:33 ` Ben Collins
2005-07-10 17:34 ` Stefan Richter
2005-07-10 18:14 ` James Bottomley
2005-07-10 20:13 ` Stefan Richter
2005-07-10 20:27 ` Ben Collins
2005-07-10 21:24 ` Stefan Richter
2005-07-10 22:06 ` Stefan Richter
2005-07-10 22:16 ` (summary) " Stefan Richter
2005-07-10 22:32 ` Stefan Richter
2005-07-11 13:57 ` James Bottomley
2005-07-13 19:56 ` Stefan Richter
2005-07-13 20:12 ` James Bottomley
2005-07-13 21:09 ` Stefan Richter
2005-07-13 22:39 ` Stefan Richter
2005-07-10 19:26 ` Stefan Richter
2005-07-10 4:21 ` James Bottomley
2005-07-09 23:31 ` Ben Collins
2005-07-10 3:29 ` Jeff Garzik
2005-07-10 4:38 ` Ben Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050709174958.GA29099@phunnypharm.org \
--to=bcollins@debian.org \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox