From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Collins Subject: Re: changes to ieee1394/sbp2 outside of linux1394.org Date: Sat, 9 Jul 2005 19:31:38 -0400 Message-ID: <20050709233138.GT29099@phunnypharm.org> References: <200507091237.j69Cbtrv003425@einhorn.in-berlin.de> <1120922306.5008.5.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1120922306.5008.5.camel@mulgrave> Sender: linux1394-devel-admin@lists.sourceforge.net Errors-To: linux1394-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: James Bottomley Cc: Stefan Richter , SCSI Mailing List , linux1394-devel@lists.sourceforge.net List-Id: linux-scsi@vger.kernel.org Ok, I see that the rw and ms 10byte conversions are in the scsi lib now. Thing is, these don't seem to be working for SBP2. I assume these conversions came from libata (since that's the only other user of them). Is that correct? Was the logic compared to the SBP2 conversions before being moved over to using them? Reverting this portion wont break anything, correct? Just means we have duplication of code (well, except that one works for us and the other doesn't). I'm going to revert this in my merge with Linus, but I will retain it in our tree until we can figure out what the problem is. -- Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ Subversion - http://subversion.tigris.org/ SwissDisk - http://www.swissdisk.com/ ------------------------------------------------------- This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual core and dual graphics technology at this free one hour event hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar