Re: sbp2: modprobe -r fails, module allegedly in use

[Ben Collins <bcollins@debian.org>]

> Actually, I think your error is the opposite of this: you should never
> have to do a scsi_host_put() unless you did a corresponding
> scsi_host_get(), which, as far as I can see, sbp2 never does, so the
> extra put should be meaningless.
> 
> Except, I notice that you don't do a scsi_device_put() after
> scsi_add_device().  I think this is probably the source of the
> refcounting errors: scsi_add_device returns an sdev with the refcount
> incremented by one, so you need to decrement the count after you've
> finished with it (in your case, you do nothing with it, so just
> decrement after you've checked it's not an error pointer).

Thanks. Stefan, can you test with that change? I've already put it in the
repo.

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
SwissDisk  - http://www.swissdisk.com/