From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: mikem <mikem@beardog.cca.cpqcorp.net>,
marcelo.tosatti@cyclades.com, Jens Axboe <axboe@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 3/4] cciss 2.4: adds 2 ioctls for ia64 based systems
Date: Mon, 15 Aug 2005 22:49:03 +0100 [thread overview]
Message-ID: <20050815214903.GA12701@infradead.org> (raw)
In-Reply-To: <1124141573.5089.55.camel@mulgrave>
On Mon, Aug 15, 2005 at 04:32:53PM -0500, James Bottomley wrote:
> On Mon, 2005-08-15 at 16:22 -0500, mikem wrote:
> > +#ifdef CONFIG_IA64
> > + case BLKGETLASTSECT:
> > + case BLKSETLASTSECT:
> > +#endif
> > return blk_ioctl(inode->i_rdev, cmd, arg);
>
> What makes these two ioctls IA64 specific? I think they're completely
> general in 2.4, so there's no need for the #ifdef.
They don't exist in 2.4 mainline. The ia64 patch and then many
distributions introduced it because the EFI partitions spec contains
some braindamage that requries accessing the last sector. In 2.6 the
block device nodes can do that, so the ioctls aren't needed either.
In short this patch should not go into mainline 2.4, it doesn't support
ia64 anyway and if it did it wouldn't compile because the ioctls aren't
defined.
prev parent reply other threads:[~2005-08-15 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-15 21:22 [PATCH 3/4] cciss 2.4: adds 2 ioctls for ia64 based systems mikem
2005-08-15 21:32 ` James Bottomley
2005-08-15 21:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050815214903.GA12701@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=mikem@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox