From: Patrick Mansfield <patmans@us.ibm.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: dm-devel@redhat.com, axboe@suse.de, linux-scsi@vger.kernel.org
Subject: Re: [RFC PATCH 1/4] convert block layer drivers to blkerr error values
Date: Wed, 24 Aug 2005 12:21:32 -0700 [thread overview]
Message-ID: <20050824192132.GA20663@us.ibm.com> (raw)
In-Reply-To: <1124874238.10888.18.camel@max>
On Wed, Aug 24, 2005 at 04:03:58AM -0500, Mike Christie wrote:
> -#define end_io_error(uptodate) (unlikely((uptodate) <= 0))
> +enum {
> + BLK_SUCCESS = 0, /* Must be zero for compat with old usage */
> + BLKERR_IO, /* Generic I/O error */
> + BLKERR_NOTSUPP, /* Operation is not supported */
> + BLKERR_WOULDBLOCK, /* Operation would block */
> + BLKERR_FATAL_DRV, /* Fatal driver error */
> + BLKERR_FATAL_DEV, /* Fatal device error */
> + BLKERR_FATAL_XPT, /* Fatal transport error */
> + BLKERR_RETRY_DRV, /* Driver error, I/O may be retried */
> + BLKERR_RETRY_DEV, /* Device error, I/O may be retried */
> + BLKERR_RETRY_XPT, /* Transport error, I/O may retried */
> +};
Do you need to add and use a BLKERR_TIMEOUT? As we can't determine the
problem area for a timeout, and if it can or should be retried.
-- Patrick Mansfield
next prev parent reply other threads:[~2005-08-24 19:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-24 9:03 [RFC PATCH 1/4] convert block layer drivers to blkerr error values Mike Christie
2005-08-24 9:49 ` Mike Christie
2005-08-24 19:21 ` Patrick Mansfield [this message]
2005-08-24 19:27 ` Mike Christie
2005-08-24 19:32 ` Jeff Garzik
2005-08-24 19:42 ` Mike Christie
2005-08-24 20:33 ` James Bottomley
2005-08-24 20:50 ` Mike Christie
2005-08-24 21:02 ` [dm-devel] " James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050824192132.GA20663@us.ibm.com \
--to=patmans@us.ibm.com \
--cc=axboe@suse.de \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).