From: Andi Kleen <ak@suse.de>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] Fix crash in aic79xx probing in scsi-misc when no hardware is present
Date: Wed, 31 Aug 2005 10:45:54 +0200 [thread overview]
Message-ID: <200508311045.54846.ak@suse.de> (raw)
aic79xx in scsi-misc would oops when no hardware was present.
Reason was a duplicated call to free the spi transport object -
it was done both in ahd_linux_exit and in the cleanup part
of ahd_linux_init.
Just remove the superfluous call.
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux-2.6.13/drivers/scsi/aic7xxx/aic79xx_osm.c
===================================================================
--- linux-2.6.13.orig/drivers/scsi/aic7xxx/aic79xx_osm.c
+++ linux-2.6.13/drivers/scsi/aic7xxx/aic79xx_osm.c
@@ -2771,7 +2771,6 @@ ahd_linux_init(void)
sizeof(struct ahd_linux_device));
if (ahd_linux_detect(&aic79xx_driver_template) > 0)
return 0;
- spi_release_transport(ahd_linux_transport_template);
ahd_linux_exit();
return -ENODEV;
}
next reply other threads:[~2005-08-31 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-31 8:45 Andi Kleen [this message]
2005-08-31 13:29 ` [PATCH] Fix crash in aic79xx probing in scsi-misc when no hardware is present James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508311045.54846.ak@suse.de \
--to=ak@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox