public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: ltuikov@yahoo.com, Luben Tuikov <luben_tuikov@adaptec.com>,
	Albert Lee <albertcc@tw.ibm.com>,
	linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
	Doug Maxey <dwm@maxeymade.com>
Subject: Re: [RFC] libata new EH document
Date: Thu, 1 Sep 2005 01:54:21 -0400	[thread overview]
Message-ID: <20050901055421.GA23496@havoc.gtf.org> (raw)
In-Reply-To: <43169520.6040008@gmail.com>

On Thu, Sep 01, 2005 at 02:44:00PM +0900, Tejun Heo wrote:
>  Can you please elaborate why getting sense data from EH is bad idea 
> for ATAPI?  For more advanced SCSI transports, I agree with you that 
> autosensing is necessary with queueing and multiple initiator and etc, 
> but I don't really see how requesting sense from EH would be bad for ATAPI.

The long term direction for the SCSI core seems to be that of
requiring auto-sensing.

libata is simply being lazy:  while the SCSI core continues to support
kicking the EH thread when sense is missing, it's preferred for libata
to reuse that infrastructure.

Auto-sensing (and READ LOG EXT for NCQ errors) requires either an
FSM or a kernel thread, to initiate a secondary qc for REQUEST SENSE.
Since the common infrastructure already exists for this, libata reuses
the existing SCSI EH kernel thread.

We should move libata-scsi to auto-sensing, but it's not an urgent priority.

	Jeff




  reply	other threads:[~2005-09-01  5:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050829061124.GA2725@htj.dyndns.org>
2005-08-30  9:10 ` [RFC] libata new EH document Albert Lee
2005-08-30 10:26   ` Tejun Heo
2005-08-30 14:32     ` Luben Tuikov
2005-09-01  1:17       ` Tejun Heo
2005-09-01  2:22         ` Jeff Garzik
2005-09-01  2:42           ` Tejun Heo
2005-09-01  3:33           ` Luben Tuikov
2005-09-01  3:30         ` Luben Tuikov
2005-09-01  3:44           ` Tejun Heo
2005-09-01  4:38             ` Luben Tuikov
2005-09-01  5:44               ` Tejun Heo
2005-09-01  5:54                 ` Jeff Garzik [this message]
2005-09-01 13:24                   ` James Bottomley
2005-09-01 21:40                     ` Luben Tuikov
2005-09-01 21:46                       ` Jeff Garzik
2005-09-01 22:09                         ` Luben Tuikov
2005-09-01 22:27                           ` Jeff Garzik
2005-09-01 23:17                             ` Luben Tuikov
2005-09-02  7:09                             ` Stefan Richter
2005-09-01 22:22                         ` Luben Tuikov
2005-09-01 22:31                           ` Jeff Garzik
2005-09-01 21:55                       ` James Bottomley
2005-09-01 22:07                         ` Luben Tuikov
2005-09-01 22:23                           ` James Bottomley
2005-09-01 22:36                             ` Luben Tuikov
2005-09-01 23:01                               ` James Bottomley
2005-09-01 23:03                                 ` Luben Tuikov
2005-09-01 23:27                                 ` Luben Tuikov
2005-09-01  2:22     ` Jeff Garzik
2005-08-30 14:27   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050901055421.GA23496@havoc.gtf.org \
    --to=jgarzik@pobox.com \
    --cc=albertcc@tw.ibm.com \
    --cc=dwm@maxeymade.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ltuikov@yahoo.com \
    --cc=luben_tuikov@adaptec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox