* [PATCH] permit READ DEFECT DATA in block/scsi_ioctl
@ 2005-09-09 10:07 Douglas Gilbert
2005-09-09 10:25 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Douglas Gilbert @ 2005-09-09 10:07 UTC (permalink / raw)
To: linux-scsi; +Cc: linux-kernel, axboe, ballen
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
The soon to be released smartmontools 5.34 uses the
READ DEFECT DATA command on SCSI disks. A disk that
has defect list entries (or worse, an increasing number
of them) is at risk.
Currently the first invocation of smartctl causes this:
scsi: unknown opcode 0x37
message to appear the console and in the log.
The READ DEFECT DATA SCSI command does not change
the state of a disk. Its opcode (0x37) is valid for
SBC devices (e.g. disks) and SMC-2 devices (media
changers) where it is called INITIALIZE STATUS ELEMENT
WITH RANGE and again doesn't change the external state
of the device.
The patch is against lk 2.6.13 .
Changelog:
- mark SCSI opcode 0x37 (READ DEFECT DATA) as
safe_for_read
Signed-off-by: Douglas Gilbert <dougg@torque.net>
Doug Gilbert
[-- Attachment #2: scsi_ioctl2613rdd.diff --]
[-- Type: text/x-patch, Size: 380 bytes --]
--- linux/drivers/block/scsi_ioctl.c 2005-06-19 07:54:59.000000000 +1000
+++ linux/drivers/block/scsi_ioctl.c2613rdd 2005-09-09 17:21:52.000000000 +1000
@@ -123,6 +123,7 @@
safe_for_read(READ_12),
safe_for_read(READ_16),
safe_for_read(READ_BUFFER),
+ safe_for_read(READ_DEFECT_DATA),
safe_for_read(READ_LONG),
safe_for_read(INQUIRY),
safe_for_read(MODE_SENSE),
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] permit READ DEFECT DATA in block/scsi_ioctl
2005-09-09 10:07 [PATCH] permit READ DEFECT DATA in block/scsi_ioctl Douglas Gilbert
@ 2005-09-09 10:25 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2005-09-09 10:25 UTC (permalink / raw)
To: Douglas Gilbert; +Cc: linux-scsi, linux-kernel, ballen
On Fri, Sep 09 2005, Douglas Gilbert wrote:
> The soon to be released smartmontools 5.34 uses the
> READ DEFECT DATA command on SCSI disks. A disk that
> has defect list entries (or worse, an increasing number
> of them) is at risk.
>
> Currently the first invocation of smartctl causes this:
> scsi: unknown opcode 0x37
> message to appear the console and in the log.
>
> The READ DEFECT DATA SCSI command does not change
> the state of a disk. Its opcode (0x37) is valid for
> SBC devices (e.g. disks) and SMC-2 devices (media
> changers) where it is called INITIALIZE STATUS ELEMENT
> WITH RANGE and again doesn't change the external state
> of the device.
>
> The patch is against lk 2.6.13 .
>
> Changelog:
> - mark SCSI opcode 0x37 (READ DEFECT DATA) as
> safe_for_read
>
> Signed-off-by: Douglas Gilbert <dougg@torque.net>
Fine with me.
Acked-by: Jens Axboe <axboe@suse.de>
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-09-09 10:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-09 10:07 [PATCH] permit READ DEFECT DATA in block/scsi_ioctl Douglas Gilbert
2005-09-09 10:25 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).