From: Christoph Hellwig <hch@lst.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>,
Christoph Hellwig <hch@lst.de>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/2] fix EH thread teardown
Date: Tue, 13 Sep 2005 21:05:36 +0200 [thread overview]
Message-ID: <20050913190536.GA26985@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0509131457530.4662-100000@iolanthe.rowland.org>
On Tue, Sep 13, 2005 at 03:03:19PM -0400, Alan Stern wrote:
> On Tue, 13 Sep 2005, Rolf Eike Beer wrote:
>
> > Looks like someone has to build a waitqueue to fix this.
>
> Tell me what you think of this patch. I'm not sure whether that
> condition, host_busy == host_failed, is correct for the call to
> wait_event_interruptible.
I don't think we even need the waitque, a wake_up_process can replace
it when there's only a single process waiting on it ever. Similarly
we don't need eh_alive - EH must be alive after scsi_add_host returned,
and no command may be in flight before that.
next prev parent reply other threads:[~2005-09-13 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 16:50 [PATCH 1/2] fix EH thread teardown Alan Stern
2005-09-13 17:01 ` Rolf Eike Beer
2005-09-13 19:03 ` Alan Stern
2005-09-13 19:05 ` Christoph Hellwig [this message]
2005-09-13 20:57 ` Alan Stern
2005-09-14 16:24 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2005-09-07 13:51 Christoph Hellwig
2005-09-07 14:01 ` Rolf Eike Beer
2005-09-08 15:26 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050913190536.GA26985@lst.de \
--to=hch@lst.de \
--cc=eike-kernel@sf-tec.de \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox