From: Christoph Hellwig <hch@infradead.org>
To: "Moore, Eric Dean" <Eric.Moore@lsil.com>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@SteelEye.com>,
linux scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH ] mptsas: support link error attributes[2 round] - and phy_reset attributes
Date: Mon, 17 Oct 2005 13:53:57 +0100 [thread overview]
Message-ID: <20051017125357.GA29491@infradead.org> (raw)
In-Reply-To: <200510121816.02479.Eric.Moore@lsil.com>
On Wed, Oct 12, 2005 at 06:16:02PM -0600, Moore, Eric Dean wrote:
> This patch applies ontop of 2.6.14-rc4
> and two patches previous posted by Christoph
>
> (1) [PATCH] mptsas: support link error attributes
> http://marc.theaimsgroup.com/?l=linux-scsi&m=112716006932685&w=2
>
> (2) [PATCH] scsi_transport_sas: support link error attributes
> http://marc.theaimsgroup.com/?l=linux-scsi&m=112716000904268&w=2
>
> This attached patch changelog as follows:
>
> (1) fix?s the proper phy_identifier attribute to be set properly
> so link_attributes returns correct values from firmware.
>
> (2) Only link_attributes work for hba attached phys. Its not implemented
> for expanders.
>
> (3) Add phy link_reset and hard_reset support. These work for
> hba attached phys, not for expanders. This was a patch previously
> provided by Christoph - added support in scsi_transport_sas.
Except for some whitespace changes and some odd bits about the reply
handle this looks good. But it really needs to be split up, we should
try to get the phy identifier fix into 2.6.14 if possible, and the
transport class bits needs to be separate from the mptsas changes for
the link reset. I'll resend some split-up patches.
next prev parent reply other threads:[~2005-10-17 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 0:16 [PATCH ] mptsas: support link error attributes[2 round] - and phy_reset attributes Moore, Eric Dean
2005-10-17 12:53 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-10-18 13:57 Moore, Eric Dean
2005-10-19 11:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051017125357.GA29491@infradead.org \
--to=hch@infradead.org \
--cc=Eric.Moore@lsil.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).