From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: ips.c warnings Date: Thu, 20 Oct 2005 18:29:14 +0100 Message-ID: <20051020172914.GA32307@infradead.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:60599 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932498AbVJTR3R (ORCPT ); Thu, 20 Oct 2005 13:29:17 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Hammer, Jack" Cc: Matthew Wilcox , akmpm@osdl.org, James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org, IpsLinux On Thu, Oct 20, 2005 at 01:25:28PM -0400, Hammer, Jack wrote: > > I have no problem trying kmap_atomic() as long as there's a sound, > technical reason for changing code that's worked well for years. > > What are the advantages/reasons of changing to use kmap_atomic() ? It > appears very few SCSI drivers use it. I think the real question is: what are these checks for. You should never get an SG list with a NULL struct page or an SGL entry that points to address 0 from the higher level code, and no other drivers checks for that condition.