From: Ralf Baechle <ralf@linux-mips.org>
To: linux-scsi@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] procfs support for sgiwd93
Date: Thu, 20 Oct 2005 19:04:34 +0100 [thread overview]
Message-ID: <20051020180434.GA24813@linux-mips.org> (raw)
So then without the offending procfs line; I assume this part should be ok.
Move the remaining bits of sgiwd93.h into sgiwd93.c; replace the use of
CMD_PER_LUN and CAN_QUEUE by raw numbers.
Signed-off-by: Thiemo Seufer <ths@networkno.de>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
drivers/scsi/sgiwd93.h | 24 ------------------------
drivers/scsi/sgiwd93.c | 5 ++---
2 files changed, 2 insertions(+), 27 deletions(-)
Index: manual-akpm.git/drivers/scsi/sgiwd93.c
===================================================================
--- manual-akpm.git.orig/drivers/scsi/sgiwd93.c
+++ manual-akpm.git/drivers/scsi/sgiwd93.c
@@ -33,7 +33,6 @@
#include "scsi.h"
#include <scsi/scsi_host.h>
#include "wd33c93.h"
-#include "sgiwd93.h"
#include <linux/stat.h>
@@ -335,10 +334,10 @@ static Scsi_Host_Template driver_templat
.eh_abort_handler = wd33c93_abort,
.eh_bus_reset_handler = sgiwd93_bus_reset,
.eh_host_reset_handler = wd33c93_host_reset,
- .can_queue = CAN_QUEUE,
+ .can_queue = 16,
.this_id = 7,
.sg_tablesize = SG_ALL,
- .cmd_per_lun = CMD_PER_LUN,
+ .cmd_per_lun = 8,
.use_clustering = DISABLE_CLUSTERING,
};
#include "scsi_module.c"
Index: manual-akpm.git/drivers/scsi/sgiwd93.h
===================================================================
--- manual-akpm.git.orig/drivers/scsi/sgiwd93.h
+++ /dev/null
@@ -1,24 +0,0 @@
-/* $Id: sgiwd93.h,v 1.5 1998/08/25 09:18:50 ralf Exp $
- * sgiwd93.h: SGI WD93 scsi definitions.
- *
- * Copyright (C) 1996 David S. Miller (dm@engr.sgi.com)
- */
-#ifndef _SGIWD93_H
-#define _SGIWD93_H
-
-#ifndef CMD_PER_LUN
-#define CMD_PER_LUN 8
-#endif
-
-#ifndef CAN_QUEUE
-#define CAN_QUEUE 16
-#endif
-
-int sgiwd93_detect(Scsi_Host_Template *);
-int sgiwd93_release(struct Scsi_Host *instance);
-const char *wd33c93_info(void);
-int wd33c93_queuecommand(Scsi_Cmnd *, void (*done)(Scsi_Cmnd *));
-int wd33c93_abort(Scsi_Cmnd *);
-int wd33c93_host_reset(Scsi_Cmnd * SCpnt);
-
-#endif /* !(_SGIWD93_H) */
next reply other threads:[~2005-10-20 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-20 18:04 Ralf Baechle [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-10-15 1:38 [PATCH] procfs support for sgiwd93 Ralf Baechle
2005-10-17 10:19 ` Arjan van de Ven
2005-10-17 10:55 ` Douglas Gilbert
2005-10-17 11:25 ` Arjan van de Ven
2005-10-17 10:43 ` Christoph Hellwig
2005-10-17 10:47 ` Ralf Baechle
2005-10-17 10:49 ` Christoph Hellwig
2005-10-17 11:22 ` Douglas Gilbert
2005-10-19 21:40 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051020180434.GA24813@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).