From: Matthew Wilcox <matthew@wil.cx>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [patch 3/6] SCSI HCIL: add scsi_scan_target()
Date: Sat, 22 Oct 2005 20:00:32 -0600 [thread overview]
Message-ID: <20051023020032.GE1605@parisc-linux.org> (raw)
In-Reply-To: <435AED69.80609@pobox.com>
On Sat, Oct 22, 2005 at 09:54:49PM -0400, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> >On Sat, Oct 22, 2005 at 09:38:49PM -0400, Jeff Garzik wrote:
> >
> >>+/**
> >>+ * scsi_scan_target - scan a target id, possibly including all LUNs on
> >>the
> >>+ * target.
> >>+ * @target: target to scan
> >>+ * @lun: Specific LUN to scan or SCAN_WILD_CARD
> >>+ * @rescan: passed to LUN scanning routines
> >>+ *
> >>+ * Description:
> >>+ * Scan the target id on @parent, @channel, and @id. Scan at least
> >>LUN 0,
> >>+ * and possibly all LUNs on the target id.
> >
> >
> >Need to fix @parent, @channel and @id in the kerneldoc.
>
> where? The above looks right to me.
"Scan the target id on @parent, @channel, and @id"
these aren't parameters to the function. How about just deleting that
sentence ...
"Scan at least LUN 0, and possibly all LUNs on @target"
next prev parent reply other threads:[~2005-10-23 2:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-23 1:36 [patch 0/6] marginalize HCIL a bit Jeff Garzik
2005-10-23 1:37 ` [patch 1/6] SCSI HCIL: s/scsi_scan_target/spi_scan_target/ Jeff Garzik
2005-10-23 1:38 ` [patch 2/6] SCSI HCIL: remove unused scsi_scan_single_target() Jeff Garzik
2005-10-23 1:53 ` Matthew Wilcox
2005-10-23 1:38 ` [patch 3/6] SCSI HCIL: add scsi_scan_target() Jeff Garzik
2005-10-23 1:50 ` Matthew Wilcox
2005-10-23 1:54 ` Jeff Garzik
2005-10-23 2:00 ` Matthew Wilcox [this message]
2005-10-23 2:42 ` Jeff Garzik
2005-10-23 2:26 ` Randy.Dunlap
2005-10-23 1:40 ` [patch 4/6] SCSI HCIL: kill all uses of spi_scan_target() Jeff Garzik
2005-10-23 1:56 ` Matthew Wilcox
2005-10-23 1:40 ` [patch 5/6] SCSI HCIL: kill spi_scan_target(), __spi_scan_target() Jeff Garzik
2005-10-23 1:41 ` [patch 6/6] SCSI HCIL: misc cleanups Jeff Garzik
2005-10-23 2:03 ` Matthew Wilcox
2005-10-23 1:45 ` [patch 0/6] marginalize HCIL a bit Jeff Garzik
2005-10-23 15:29 ` James Bottomley
2005-10-24 15:49 ` Luben Tuikov
2005-10-24 16:50 ` James Bottomley
2005-10-24 17:18 ` Luben Tuikov
2005-10-24 20:28 ` James Bottomley
2005-10-24 20:41 ` Luben Tuikov
2005-10-24 21:12 ` James Bottomley
2005-10-24 22:38 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051023020032.GE1605@parisc-linux.org \
--to=matthew@wil.cx \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).