From: Christoph Hellwig <hch@lst.de>
To: Roland Dreier <rolandd@cisco.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
openib-general@openib.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
Date: Tue, 1 Nov 2005 05:58:00 +0100 [thread overview]
Message-ID: <20051101045800.GA25519@lst.de> (raw)
In-Reply-To: <52irvdge6c.fsf@cisco.com>
On Mon, Oct 31, 2005 at 08:55:23PM -0800, Roland Dreier wrote:
> Anyway, looking at drivers/scsi/ibmvscsi/srp.h, the main problem I see
> is that the file has a bunch of bitfields that are big-endian only
> (which makes sense because the driver can only be compiled for pSeries
> or iSeries anyway).
>
> But I have no objection to moving the file to include/scsi/srp.h,
> adding a bunch of
>
> #if defined(__LITTLE_ENDIAN_BITFIELD)
> #elif defined(__BIG_ENDIAN_BITFIELD)
> #endif
>
> and adding a few missing defines, and then converting ib_srp to use
> the same file.
>
> Does that seem like the right thing to do?
No. Bitfields for accessing hardware/wire datastructures are wrong and
will always break in some circumstances. Your header is much better.
>
> Thanks,
> Roland
> _______________________________________________
> openib-general mailing list
> openib-general@openib.org
> http://openib.org/mailman/listinfo/openib-general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
---end quoted text---
next prev parent reply other threads:[~2005-11-01 4:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 17:23 [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator Roland Dreier
2005-11-01 0:28 ` [openib-general] " Grant Grundler
2005-11-01 4:51 ` Roland Dreier
2005-11-02 21:34 ` [PATCH/RFC v2] " Roland Dreier
2005-11-02 22:03 ` Michael S. Tsirkin
2005-11-02 22:04 ` Roland Dreier
2005-11-02 22:08 ` Roland Dreier
2005-11-01 2:04 ` [PATCH/RFC] " FUJITA Tomonori
2005-11-01 4:55 ` Roland Dreier
2005-11-01 4:58 ` Christoph Hellwig [this message]
2005-11-01 5:03 ` Roland Dreier
2005-11-01 5:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051101045800.GA25519@lst.de \
--to=hch@lst.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).