From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator Date: Tue, 1 Nov 2005 05:58:00 +0100 Message-ID: <20051101045800.GA25519@lst.de> References: <52wtjtk3d1.fsf@cisco.com> <20051101110409V.fujita.tomonori@lab.ntt.co.jp> <52irvdge6c.fsf@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.210]:6317 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S932575AbVKAE6K (ORCPT ); Mon, 31 Oct 2005 23:58:10 -0500 Content-Disposition: inline In-Reply-To: <52irvdge6c.fsf@cisco.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Roland Dreier Cc: FUJITA Tomonori , openib-general@openib.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org On Mon, Oct 31, 2005 at 08:55:23PM -0800, Roland Dreier wrote: > Anyway, looking at drivers/scsi/ibmvscsi/srp.h, the main problem I see > is that the file has a bunch of bitfields that are big-endian only > (which makes sense because the driver can only be compiled for pSeries > or iSeries anyway). > > But I have no objection to moving the file to include/scsi/srp.h, > adding a bunch of > > #if defined(__LITTLE_ENDIAN_BITFIELD) > #elif defined(__BIG_ENDIAN_BITFIELD) > #endif > > and adding a few missing defines, and then converting ib_srp to use > the same file. > > Does that seem like the right thing to do? No. Bitfields for accessing hardware/wire datastructures are wrong and will always break in some circumstances. Your header is much better. > > Thanks, > Roland > _______________________________________________ > openib-general mailing list > openib-general@openib.org > http://openib.org/mailman/listinfo/openib-general > > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general ---end quoted text---