From: Christoph Hellwig <hch@lst.de>
To: Roland Dreier <rolandd@cisco.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-kernel@vger.kernel.org, openib-general@openib.org,
linux-scsi@vger.kernel.org
Subject: Re: Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
Date: Tue, 1 Nov 2005 06:04:23 +0100 [thread overview]
Message-ID: <20051101050423.GA25691@lst.de> (raw)
In-Reply-To: <52acgpgdso.fsf@cisco.com>
On Mon, Oct 31, 2005 at 09:03:35PM -0800, Roland Dreier wrote:
> Christoph> No. Bitfields for accessing hardware/wire
> Christoph> datastructures are wrong and will always break in some
> Christoph> circumstances. Your header is much better.
>
> OK, that's my feeling as well.
>
> Would it make sense for me to split the pure SRP spec structures and
> so on into a separate file and put it in include/scsi/srp.h? Then we
> can move ibmvscsi towards using that file.
Sounds like a good idea, yes.
prev parent reply other threads:[~2005-11-01 5:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 17:23 [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator Roland Dreier
2005-11-01 0:28 ` [openib-general] " Grant Grundler
2005-11-01 4:51 ` Roland Dreier
2005-11-02 21:34 ` [PATCH/RFC v2] " Roland Dreier
2005-11-02 22:03 ` Michael S. Tsirkin
2005-11-02 22:04 ` Roland Dreier
2005-11-02 22:08 ` Roland Dreier
2005-11-01 2:04 ` [PATCH/RFC] " FUJITA Tomonori
2005-11-01 4:55 ` Roland Dreier
2005-11-01 4:58 ` [openib-general] " Christoph Hellwig
2005-11-01 5:03 ` Roland Dreier
2005-11-01 5:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051101050423.GA25691@lst.de \
--to=hch@lst.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).