From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Chris Wright <chrisw@osdl.org>
Cc: Ashutosh Naik <ashutosh.naik@gmail.com>,
support@qlogic.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, stable@kernel.org
Subject: Re: [stable] Re: [PATCH] scsi - Fix Broken Qlogic ISP2x00 Device Driver
Date: Wed, 2 Nov 2005 10:47:05 -0800 [thread overview]
Message-ID: <20051102184705.GD5889@plapn> (raw)
In-Reply-To: <20051102082142.GW5856@shell0.pdx.osdl.net>
On Wed, 02 Nov 2005, Chris Wright wrote:
> * Andrew Vasquez (andrew.vasquez@qlogic.com) wrote:
> > On Wed, 02 Nov 2005, Ashutosh Naik wrote:
> >
> > > This patch fixes the fact that although the scsi_transport_fc.h header
> > > file is not included in qla_def.h, we still reference the function
> > > fc_remote_port_unlock in the qlogic ISP2x00 device driver ,
> > > qla2xxx/qla_rscn.c
> >
> > Perhaps for the stable tree (2.6.14.x) this fix is appropriate. The
> > scsi-misc-2.6.git tree already has codes which address this issue.
>
> It's preferable to have that fix pending in scsi-misc for -stable.
Sure. But, the interface changes present in scsi-misc-2.6, notably:
http://kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=19a7b4aebf9ad435c69a7e39930338499af4d152
obviate the need for the explicit '#include' -- there are no longer
any explicit calls to the fc_remote_port_*() functions within
qla_rscn.c.
Regards,
Andrew Vasquez
next prev parent reply other threads:[~2005-11-02 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 7:13 [PATCH] scsi - Fix Broken Qlogic ISP2x00 Device Driver Ashutosh Naik
2005-11-02 8:07 ` Andrew Vasquez
2005-11-02 8:21 ` [stable] " Chris Wright
2005-11-02 18:47 ` Andrew Vasquez [this message]
2005-11-05 4:56 ` Ashutosh Naik
2005-11-02 18:57 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102184705.GD5889@plapn \
--to=andrew.vasquez@qlogic.com \
--cc=ashutosh.naik@gmail.com \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@kernel.org \
--cc=support@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox