From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [2.6 patch] removed useless SCSI_GENERIC_NCR5380_MMIO Date: Sat, 12 Nov 2005 07:10:47 +0000 Message-ID: <20051112071047.GA29051@infradead.org> References: <20051112043707.GX5376@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:44518 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932197AbVKLHKw (ORCPT ); Sat, 12 Nov 2005 02:10:52 -0500 Content-Disposition: inline In-Reply-To: <20051112043707.GX5376@stusta.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Adrian Bunk Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org On Sat, Nov 12, 2005 at 05:37:07AM +0100, Adrian Bunk wrote: > This patch removes the useless SCSI_GENERIC_NCR5380_MMIO. > > It's useless, since SCSI_G_NCR5380_MEM != CONFIG_SCSI_G_NCR5380_MEM. > > This issue exists at least since kernel 2.6.0 and since it seems noone > noticed it I'd say we can safely remove it. NACK. I know at least Alan has hardware and might want to bring it forward. A better fix would be to convert the generic ncr5380 driver to use ioread*/iowrite* so it can cover both mmio and pio in a single binary.