Re: [PATCH] libata error handling fixes (ATAPI)

Jens Axboe
2005-11-16T13:47:11Z

On Wed, Nov 16 2005, Jeff Garzik wrote:
> Jens Axboe wrote:
> >I updated that patch, and converted IDE and SCSI to use it. See the
> >results here:
> >
> >http://brick.kernel.dk/git/?p=linux-2.6-block.git;a=shortlog;h=blk-softirq
> >
> >The main change from the version posted last october is killing the
> >'slightly' overdesigned completion queue hashing.
>
> Oh yeah: you shouldn't need to make scsi_retry_command() exported.
> It's private to scsi, to just publish it in scsi_priv.h.

Oh right, I'll make that change. Thanks!

> Tangent: As part of my libata work, I'm thinking about un-exporting
> scsi_finish_command(), and instead exporting scsi_eh_flush_done_q() and
> scsi_eh_finish_cmd().

Sounds ok.

--
Jens Axboe