Re: [PATCH] libata error handling fixes (ATAPI)

Jeff Garzik
2005-11-16T13:31:53Z

Jens Axboe wrote:
> I updated that patch, and converted IDE and SCSI to use it. See the
> results here:
>
> http://brick.kernel.dk/git/?p=linux-2.6-block.git;a=shortlog;h=blk-softirq
>
> The main change from the version posted last october is killing the
> 'slightly' overdesigned completion queue hashing.

Oh yeah: you shouldn't need to make scsi_retry_command() exported.
It's private to scsi, to just publish it in scsi_priv.h.

Tangent: As part of my libata work, I'm thinking about un-exporting
scsi_finish_command(), and instead exporting scsi_eh_flush_done_q() and
scsi_eh_finish_cmd().

Jeff