From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
markus.lidel@shadowconnect.com, James.Bottomley@SteelEye.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Salyzyn <mark_salyzyn@adaptec.com>
Subject: Re: [patch] drivers/scsi/dpt_i2o.c: fix a NULL pointer dereference
Date: Sun, 27 Nov 2005 11:28:25 -0200 [thread overview]
Message-ID: <20051127132825.GB21383@logos.cnet> (raw)
In-Reply-To: <20051127185252.GG3988@stusta.de>
On Sun, Nov 27, 2005 at 07:52:52PM +0100, Adrian Bunk wrote:
> On Sun, Nov 27, 2005 at 10:47:38AM -0200, Marcelo Tosatti wrote:
> > On Sun, Nov 27, 2005 at 12:36:37AM +0100, Adrian Bunk wrote:
> > > The Coverity checker spotted this obvious NULL pointer dereference.
> >
> > Hi Adrian,
>
> Hi Marcelo,
>
> > Could you explain why you remove the adpt_post_wait_lock acquision?
> >
> > And if it does not belong there, why don't you remove it instead of
> > commeting out?
> >...
>
> my patch does remove the following not required line:
>
> > > - p2 = NULL;
>
> It does not touch the following line that was already commented out:
>
> > > // spin_lock_irqsave(&adpt_post_wait_lock, flags);
> >...
Doh. I should _read_ the patch.
next prev parent reply other threads:[~2005-11-27 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-26 23:36 [patch] drivers/scsi/dpt_i2o.c: fix a NULL pointer dereference Adrian Bunk
2005-11-27 12:47 ` Marcelo Tosatti
2005-11-27 18:52 ` Adrian Bunk
2005-11-27 13:28 ` Marcelo Tosatti [this message]
2005-11-28 18:37 ` James Bottomley
2005-11-28 21:51 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-11-23 22:34 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051127132825.GB21383@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=markus.lidel@shadowconnect.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox