From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [patch] drivers/scsi/dpt_i2o.c: fix a NULL pointer dereference Date: Mon, 28 Nov 2005 22:51:43 +0100 Message-ID: <20051128215143.GE31395@stusta.de> References: <20051126233637.GC3988@stusta.de> <1133203032.3325.46.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1133203032.3325.46.camel@mulgrave> Sender: linux-kernel-owner@vger.kernel.org To: James Bottomley Cc: Linus Torvalds , Andrew Morton , Marcelo Tosatti , markus.lidel@shadowconnect.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Salyzyn List-Id: linux-scsi@vger.kernel.org On Mon, Nov 28, 2005 at 12:37:11PM -0600, James Bottomley wrote: > On Sun, 2005-11-27 at 00:36 +0100, Adrian Bunk wrote: > > The Coverity checker spotted this obvious NULL pointer dereference. > > It's a bit late for this one, since Linus already put it in, but for > future reference, could you please try to use proper descriptions. This > isn't an "obvious NULL pointer dereference", it's actually a use after > free of a data structure. OK sorry, I'll look better at the descriptions for future patches. > Thanks, > > James cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed