From: Jens Axboe <axboe@suse.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Patrick Mansfield <patmans@us.ibm.com>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: Device flags: use_10_for_rw and use_10_for_ms
Date: Wed, 30 Nov 2005 15:51:35 +0100 [thread overview]
Message-ID: <20051130145134.GP15804@suse.de> (raw)
In-Reply-To: <1133361995.3312.0.camel@mulgrave>
On Wed, Nov 30 2005, James Bottomley wrote:
> On Wed, 2005-11-30 at 09:08 +0100, Jens Axboe wrote:
> > Oh well, so much for expecting than even the most basic SCSI behaviour
> > is always implemented correctly. A device must only return
> > 0x05/0x20/0x00 for an illegal opcode. It's a little suspicious I'd say,
> > are you sure it isn't something else affecting this? Even though there
> > are crappy devices out there, this seems a little too odd to me.
>
> And anyway, just because it doesn't actually work in the failing case
> doesn't mean this isn't a good patch ... it's certainly unsafe to switch
> back to 6 byte commands without checking for the correct illegal opcode
> sense, so we should put it in anyway.
Yup, I think so too.
--
Jens Axboe
prev parent reply other threads:[~2005-11-30 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-28 21:43 Device flags: use_10_for_rw and use_10_for_ms Alan Stern
2005-11-29 20:03 ` Jens Axboe
2005-11-29 21:23 ` Alan Stern
2005-11-29 22:48 ` Patrick Mansfield
2005-11-30 15:46 ` Alan Stern
2005-11-30 8:08 ` Jens Axboe
2005-11-30 14:46 ` James Bottomley
2005-11-30 14:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051130145134.GP15804@suse.de \
--to=axboe@suse.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).