From: Jens Axboe <axboe@suse.de>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Andrew de Quincey <adq_dvb@lidskialf.net>,
linux1394-devel@lists.sourceforge.net,
linux-scsi@vger.kernel.org
Subject: Re: linux kernel panic when ejecting ieee1394 ipod
Date: Fri, 9 Dec 2005 14:37:43 +0100 [thread overview]
Message-ID: <20051209133743.GN26185@suse.de> (raw)
In-Reply-To: <20051208173429.GA2666@us.ibm.com>
On Thu, Dec 08 2005, Patrick Mansfield wrote:
> On Thu, Dec 08, 2005 at 03:44:42AM +0100, Stefan Richter wrote:
>
> > What if you replace WRITE by READ in
> > drivers/scsi/scsi_ioctl.c::scsi_cmd_ioctl()::case CDROMEJECT ?
>
> You must mean block/scsi_ioctl.c? i.e.:
>
> diff -uprN -X /home/patman/dontdiff linux-2.6.15-rc5-git1/block/scsi_ioctl.c mod- linux-2.6.15-rc5-git1/block/scsi_ioctl.c
> --- /home/linux/views/linux-2.6.15-rc5-git1/block/scsi_ioctl.c 2005-12-03 22:51:54.000000000 -0800
> +++ linux-2.6.15-rc5-git1/block/scsi_ioctl.c 2005-12-08 09:31:52.000000000 -0800
> @@ -566,7 +566,7 @@ int scsi_cmd_ioctl(struct file *file, st
> case CDROMCLOSETRAY:
> close = 1;
> case CDROMEJECT:
> - rq = blk_get_request(q, WRITE, __GFP_WAIT);
> + rq = blk_get_request(q, READ, __GFP_WAIT);
> rq->flags |= REQ_BLOCK_PC;
> rq->data = NULL;
> rq->data_len = 0;
This should not make a difference, the direction flag must be ignored
for !rq->data_len. Similarly you could translate the request with the
change above into DMA_FROM_DEVICE which is clearly false as well. So it
must be a bug somewhere that somebody only looks at the direction flag.
--
Jens Axboe
next prev parent reply other threads:[~2005-12-09 13:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200512072358.15398.adq_dvb@lidskialf.net>
2005-12-08 1:17 ` linux kernel panic when ejecting ieee1394 ipod Stefan Richter
2005-12-08 1:57 ` Andrew de Quincey
[not found] ` <200512080119.48740.adq@lidskialf.net>
2005-12-08 1:59 ` Andrew de Quincey
2005-12-08 2:09 ` Andrew de Quincey
2005-12-08 2:44 ` Stefan Richter
2005-12-08 3:19 ` Andrew de Quincey
2005-12-08 7:52 ` Stefan Richter
2005-12-08 19:27 ` Stefan Richter
2005-12-08 17:34 ` Patrick Mansfield
2005-12-08 19:25 ` Stefan Richter
2005-12-09 13:37 ` Jens Axboe [this message]
2005-12-09 13:42 ` Jens Axboe
2005-12-09 18:39 ` Stefan Richter
2005-12-09 19:35 ` Stefan Richter
2005-12-09 22:45 ` James Bottomley
2005-12-10 18:20 ` Christoph Hellwig
2005-12-13 20:44 ` Stefan Richter
2005-12-13 20:54 ` Jens Axboe
2005-12-10 8:48 ` Jens Axboe
2005-12-10 9:28 ` Christoph Hellwig
2005-12-10 10:55 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051209133743.GN26185@suse.de \
--to=axboe@suse.de \
--cc=adq_dvb@lidskialf.net \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=patmans@us.ibm.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox