From: Christoph Hellwig <hch@infradead.org>
To: Martin Peschke <mp3@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, linux-scsi@vger.kernel.org
Subject: Re: [patch 6/6] statistics infrastructure - exploitation: zfcp
Date: Wed, 14 Dec 2005 16:59:00 +0000 [thread overview]
Message-ID: <20051214165900.GA26580@infradead.org> (raw)
In-Reply-To: <43A044E6.7060403@de.ibm.com>
> + atomic_t read_num;
> + atomic_t write_num;
> + struct statistic_interface *stat_if;
> + struct statistic *stat_sizes_scsi_write;
> + struct statistic *stat_sizes_scsi_read;
> + struct statistic *stat_sizes_scsi_nodata;
> + struct statistic *stat_sizes_scsi_nofit;
> + struct statistic *stat_sizes_scsi_nomem;
> + struct statistic *stat_sizes_timedout_write;
> + struct statistic *stat_sizes_timedout_read;
> + struct statistic *stat_sizes_timedout_nodata;
> + struct statistic *stat_latencies_scsi_write;
> + struct statistic *stat_latencies_scsi_read;
> + struct statistic *stat_latencies_scsi_nodata;
> + struct statistic *stat_pending_scsi_write;
> + struct statistic *stat_pending_scsi_read;
> + struct statistic *stat_erp;
> + struct statistic *stat_eh_reset;
NACK. pretty much all of this is generic and doesn't belong into an LLDD.
We already had this statistics things with emulex and they added various
bits to the core in response.
next prev parent reply other threads:[~2005-12-14 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 16:14 [patch 6/6] statistics infrastructure - exploitation: zfcp Martin Peschke
2005-12-14 16:24 ` Matthew Wilcox
2005-12-14 16:55 ` Martin Peschke
2005-12-14 17:17 ` Heiko Carstens
2005-12-14 16:59 ` Christoph Hellwig [this message]
2005-12-15 3:54 ` Martin Peschke
2005-12-15 7:37 ` Arjan van de Ven
2005-12-15 11:23 ` Martin Peschke
2005-12-15 11:46 ` Arjan van de Ven
2005-12-15 14:38 ` Martin Peschke
-- strict thread matches above, loose matches on Subject: below --
2005-12-15 15:27 James.Smart
2005-12-15 17:47 ` Martin Peschke
2005-12-31 6:55 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051214165900.GA26580@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mp3@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox