From: Matthew Wilcox <matthew@wil.cx>
To: linux-scsi@vger.kernel.org
Subject: target_alloc is noisy on failure
Date: Sun, 18 Dec 2005 12:29:25 -0700 [thread overview]
Message-ID: <20051218192925.GM2361@parisc-linux.org> (raw)
I'm looking at moving this code from slave_alloc to target_alloc:
tp->starget = sdev->sdev_target;
if (tp->usrflags & SYM_SCAN_BOOT_DISABLED) {
tp->usrflags &= ~SYM_SCAN_BOOT_DISABLED;
starget_printk(KERN_INFO, tp->starget,
"Scan at boot disabled in NVRAM\n");
return -ENXIO;
}
However, returning an error from target_alloc is noisy:
int error = shost->hostt->target_alloc(starget);
if(error) {
dev_printk(KERN_ERR, dev,
"target allocation failed, error %d\n", error);
so I don't really want to do this. Any thoughts on defining some
'quiet' return values from target_alloc?
next reply other threads:[~2005-12-18 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-18 19:29 Matthew Wilcox [this message]
2005-12-18 19:48 ` target_alloc is noisy on failure James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051218192925.GM2361@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox