From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] dont decrement counters from scsi_kill_request Date: Wed, 4 Jan 2006 09:00:02 +0000 Message-ID: <20060104090002.GA24879@infradead.org> References: <1136360688.9634.2.camel@max> <200601040852.15700@bilbo.math.uni-mannheim.de> <20060104080518.GO27946@ftp.linux.org.uk> <200601040913.42413@bilbo.math.uni-mannheim.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:55487 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751603AbWADJAP (ORCPT ); Wed, 4 Jan 2006 04:00:15 -0500 Content-Disposition: inline In-Reply-To: <200601040913.42413@bilbo.math.uni-mannheim.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Rolf Eike Beer Cc: Al Viro , Mike Christie , linux-scsi@vger.kernel.org On Wed, Jan 04, 2006 at 09:13:36AM +0100, Rolf Eike Beer wrote: > Al Viro wrote: > >On Wed, Jan 04, 2006 at 08:51:57AM +0100, Rolf Eike Beer wrote: > >> Mike Christie wrote: > >> >+ while (end_that_request_first(req, 0, req->nr_sectors)) > >> >+ ; > >> > >> This should be something like > >> > >> while (...) > >> {} > >> > >> so it is absolutely clear that the empty body is intentional. > > > >Please, do not inflict that ugliness on everyone. FWIW, it's less > >idiomatic than normal use of ; and personally I'd parse it as "somebody > >had fscked up using editor", not as "wow, they _really_ meant it to be > >an empty body". > > Using only ; on a single line looks like some code left over from removing > code... It's a common idiom and above code is copy and pasted from a perfectly fine indented function. So could you please stop this silly discussion now?