From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Mike Christie <michaelc@cs.wisc.edu>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] dont decrement counters from scsi_kill_request
Date: Wed, 4 Jan 2006 09:13:36 +0100 [thread overview]
Message-ID: <200601040913.42413@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <20060104080518.GO27946@ftp.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
Al Viro wrote:
>On Wed, Jan 04, 2006 at 08:51:57AM +0100, Rolf Eike Beer wrote:
>> Mike Christie wrote:
>> >+ while (end_that_request_first(req, 0, req->nr_sectors))
>> >+ ;
>>
>> This should be something like
>>
>> while (...)
>> {}
>>
>> so it is absolutely clear that the empty body is intentional.
>
>Please, do not inflict that ugliness on everyone. FWIW, it's less
>idiomatic than normal use of ; and personally I'd parse it as "somebody
>had fscked up using editor", not as "wow, they _really_ meant it to be
>an empty body".
Using only ; on a single line looks like some code left over from removing
code... Ok, so let's agree to disagree. Since coding style says the opening
brace should be on the same line as the while, would it be better to put
everthing in one line to make clear what's going on?
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-01-04 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 7:44 [PATCH] dont decrement counters from scsi_kill_request Mike Christie
2006-01-04 7:51 ` Rolf Eike Beer
2006-01-04 8:05 ` Al Viro
2006-01-04 8:13 ` Rolf Eike Beer [this message]
2006-01-04 9:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601040913.42413@bilbo.math.uni-mannheim.de \
--to=eike-kernel@sf-tec.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox