From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: "Moore, Eric" <Eric.Moore@lsil.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] - pci_ids - adding pci device id support for FC949ES
Date: Fri, 13 Jan 2006 18:10:02 +0000 [thread overview]
Message-ID: <20060113181002.GG20718@infradead.org> (raw)
In-Reply-To: <20060113000323.09cbff98.akpm@osdl.org>
On Fri, Jan 13, 2006 at 12:03:23AM -0800, Andrew Morton wrote:
> > --- b/include/linux/pci_ids.h 2006-01-11 19:04:18.000000000 -0700
> > +++ a/include/linux/pci_ids.h 2006-01-12 14:19:43.000000000 -0700
> > @@ -181,6 +181,7 @@
> > #define PCI_DEVICE_ID_LSI_FC929X 0x0626
> > #define PCI_DEVICE_ID_LSI_FC939X 0x0642
> > #define PCI_DEVICE_ID_LSI_FC949X 0x0640
> > +#define PCI_DEVICE_ID_LSI_FC949ES 0x0646
> > #define PCI_DEVICE_ID_LSI_FC919X 0x0628
> > #define PCI_DEVICE_ID_NCR_YELLOWFIN 0x0701
> > #define PCI_DEVICE_ID_LSI_61C102 0x0901
>
> That doesn't add support - it just adds the ID. We've apparently decided
> not to keep IDs of devices which the kernel doesn't support.
There's a patch on linux-scsi that adds the actual support.
> Also, there's a plan to stop using pci_ids.h - PCI IDs are supposed to go
> into a driver-private header file. I guess drivers/scsi/megaraid.h is an
> example.
That's new to me. In either case a single driver should do one thing
consistantly, and fusion has tons of defines in pci_ids.h already.
next prev parent reply other threads:[~2006-01-13 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 21:28 [PATCH] - pci_ids - adding pci device id support for FC949ES Moore, Eric
2006-01-13 8:03 ` Andrew Morton
2006-01-13 18:10 ` Christoph Hellwig [this message]
2006-01-13 19:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060113181002.GG20718@infradead.org \
--to=hch@infradead.org \
--cc=Eric.Moore@lsil.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox