Re: [PATCH] remove target parent limitiation

Mike Christie
2006-01-13T18:22:21Z

Christoph Hellwig wrote:
> ===================================================================
> --- scsi-misc-2.6.orig/drivers/scsi/scsi_scan.c 2006-01-13 17:55:57.000000000 +0100
> +++ scsi-misc-2.6/drivers/scsi/scsi_scan.c 2006-01-13 18:26:17.000000000 +0100
> @@ -334,19 +334,6 @@
> struct scsi_target *starget;
> struct scsi_target *found_target;
>
> - /*
> - * Obtain the real parent from the transport. The transport
> - * is allowed to fail (no error) if there is nothing at that
> - * target id.
> - */
> - if (shost->transportt->target_parent) {
> - spin_lock_irqsave(shost->host_lock, flags);
> - parent = shost->transportt->target_parent(shost, channel, id);
> - spin_unlock_irqrestore(shost->host_lock, flags);
> - if (!parent)
> - return NULL;
> - }

Should we remove the target_parent callout from the trasnport_template
since it is no longer used or does it make sense to keep it as part of
the API?