Re: [PATCH] remove target parent limitiation

Christoph Hellwig
2006-01-13T19:37:51Z

On Fri, Jan 13, 2006 at 12:01:53PM -0700, Moore, Eric wrote:
> On Friday, January 13, 2006 11:04 AM, Christoph Hellwig wrote:
>
> > When James Smart fixed the issue of the userspace scan atributes
> > crashing the system with the FC transport class he added a patch to
> > let the transport class check if the parent is valid for a given
> > transport class.
> >
> > When adding support for the integrated raid of fusion sas devices
> > we ran into a problem with that, as it didn't allow adding virtual
> > raid volumes without the transport class knowing about it.
> >
> > So this patch adds a user_scan attribute instead, that takes over from
> > scsi_scan_host_selected if the transport class sets it and thus lets
> > the transport class control the user-initiated scanning. As this
> > plugs the hole about user-initiated scanning the target_parent hook
> > goes away and we rely on callers of the scanning routines to do
> > something sensible.
> >
> > For SAS this meant I had to switch from a spinlock to a mutex to
> > synchronize the topology linked lists, in FC they were completely
> > unsynchronized which seems wrong.
> >
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
>
> I noticed that rebasing the James git tree this morning, and
> applying this patch, the following was missing. This patch
> submitted earlier by Christoph solves the panic that occurs when
> unloading the mptsas modules, and reloading. Please apply.

James put this in alraedy.