linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mptsas: don't complain on bogus slave_alloc calls
@ 2006-01-30 18:00 Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2006-01-30 18:00 UTC (permalink / raw)
  To: jejb, Eric.Moore; +Cc: linux-scsi

When people use the userspace scanning facilities on SAS hardware the
LLDD gets bogus slave_alloc calls.  Just fail those gracefully instead
of printing a warning in mptsas and another one in the midlayer.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/drivers/message/fusion/mptsas.c
===================================================================
--- linux-2.6.orig/drivers/message/fusion/mptsas.c	2006-01-15 21:45:28.000000000 +0100
+++ linux-2.6/drivers/message/fusion/mptsas.c	2006-01-30 18:52:58.000000000 +0100
@@ -301,9 +301,8 @@
 	}
 	mutex_unlock(&hd->ioc->sas_topology_mutex);
 
-	printk("No matching SAS device found!!\n");
 	kfree(vdev);
-	return -ENODEV;
+	return -ENXIO;
 
  out:
 	vtarget->ioc_id = vdev->ioc_id;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] mptsas: don't complain on bogus slave_alloc calls
@ 2006-01-30 19:49 Moore, Eric
  0 siblings, 0 replies; 2+ messages in thread
From: Moore, Eric @ 2006-01-30 19:49 UTC (permalink / raw)
  To: Christoph Hellwig, jejb; +Cc: linux-scsi

On Monday, January 30, 2006 11:01 AM, Christoph Hellwig wrote:

> 
> When people use the userspace scanning facilities on SAS hardware the
> LLDD gets bogus slave_alloc calls.  Just fail those gracefully instead
> of printing a warning in mptsas and another one in the midlayer.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 

ACK, pls apply.

Signed-off-by: Eric Moore <Eric.Moore@lsil.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-30 19:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-30 18:00 [PATCH] mptsas: don't complain on bogus slave_alloc calls Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2006-01-30 19:49 Moore, Eric

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).