From: Andrew Morton <akpm@osdl.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: bugme-daemon@bugzilla.kernel.org, linux-scsi@vger.kernel.org,
greg@kroah.com
Subject: Re: [Bug 6009] tcpdump causes kernel panic
Date: Sat, 4 Feb 2006 16:51:56 -0800 [thread overview]
Message-ID: <20060204165156.6024702b.akpm@osdl.org> (raw)
In-Reply-To: <1139098731.2957.2.camel@mulgrave.il.steeleye.com>
James Bottomley <James.Bottomley@SteelEye.com> wrote:
>
> On Sat, 2006-02-04 at 15:31 -0800, Andrew Morton wrote:
> > James, I don't recall whether we've fixed this or not? It was non-trivial,
> > wasn't it?
>
> It's not fixed, and pretty non-trivial. Basically we'd have to redo
> most of our generic device (or kobject) handling through workqueues.
>
> What I'd like for this is a way to tell context. We know the locking
> context and can cope with that, but it would be nice to tell if we have
> user context or not and then only go through the workqueue for the
> softirq or hardirq contexts.
>
> If we can get the check, it would probably make sense to do the actual
> manipulation in put_device().
>
in_interrupt() will return true in hard- or soft-irq context on all
architectures and all .configs - you can certainly use that.
What we cannot use is in_atomic() to detect whether we're inside spinlock -
that only works if CONFIG_PREEMPT.
Regarding this bug, Donny: are you saying that the 3ware failure is caused
by putting the NIC into promiscuous mode (or something related)? That it
is caused by running tcpdump?
next prev parent reply other threads:[~2006-02-05 0:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200602042315.k14NFwuS006966@fire-2.osdl.org>
2006-02-04 23:31 ` [Bug 6009] tcpdump causes kernel panic Andrew Morton
2006-02-05 0:18 ` James Bottomley
2006-02-05 0:51 ` Andrew Morton [this message]
2006-02-05 18:02 ` James Bottomley
2006-02-10 6:18 ` Greg KH
[not found] <200602050242.k152giEp014748@fire-2.osdl.org>
2006-02-05 5:04 ` Andrew Morton
[not found] <200602041838.k14Ic4Pi028741@fire-2.osdl.org>
2006-02-04 18:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060204165156.6024702b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=James.Bottomley@SteelEye.com \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=greg@kroah.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox