From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: [-mm patch] drivers/scsi/gdth.c: make __gdth_execute() static Date: Fri, 10 Feb 2006 01:37:37 +0100 Message-ID: <20060210003737.GH3524@stusta.de> References: <20060207220627.345107c3.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from emailhub.stusta.mhn.de ([141.84.69.5]:51717 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1750880AbWBJAhi (ORCPT ); Thu, 9 Feb 2006 19:37:38 -0500 Content-Disposition: inline In-Reply-To: <20060207220627.345107c3.akpm@osdl.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Andrew Morton , Christoph Hellwig Cc: linux-kernel@vger.kernel.org, achim_leubner@adaptec.com, linux-scsi@vger.kernel.org On Tue, Feb 07, 2006 at 10:06:27PM -0800, Andrew Morton wrote: >... > Changes since 2.6.16-rc1-mm5: >... > +gdth-add-execute-firmware-command-abstraction.patch > > scsi driver API modernisation >... I don't see any reason for __gdth_execute() being global. Signed-off-by: Adrian Bunk --- drivers/scsi/gdth.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-2.6.16-rc2-mm1-full/drivers/scsi/gdth.c.old 2006-02-10 00:49:53.000000000 +0100 +++ linux-2.6.16-rc2-mm1-full/drivers/scsi/gdth.c 2006-02-10 00:51:05.000000000 +0100 @@ -693,8 +693,8 @@ complete(scp->request->waiting); } -int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd, - int timeout, u32 *info) +static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, + char *cmnd, int timeout, u32 *info) { struct scsi_request *scp = scsi_allocate_request(sdev, GFP_KERNEL); unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0; @@ -727,8 +727,8 @@ complete(scp->request.waiting); } -int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd, - int timeout, u32 *info) +static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, + char *cmnd, int timeout, u32 *info) { Scsi_Cmnd *scp = scsi_allocate_device(sdev, 1, FALSE); unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0;