[-mm patch] drivers/scsi/gdth.c: make __gdth_execute() static

[-mm patch] drivers/scsi/gdth.c: make __gdth_execute() static

[Adrian Bunk]

On Tue, Feb 07, 2006 at 10:06:27PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc1-mm5:
>...
> +gdth-add-execute-firmware-command-abstraction.patch
> 
>  scsi driver API modernisation
>...


I don't see any reason for __gdth_execute() being global.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/scsi/gdth.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-2.6.16-rc2-mm1-full/drivers/scsi/gdth.c.old	2006-02-10 00:49:53.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/drivers/scsi/gdth.c	2006-02-10 00:51:05.000000000 +0100
@@ -693,8 +693,8 @@
 		complete(scp->request->waiting);
 }
 
-int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd,
-		 int timeout, u32 *info)
+static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd,
+			  char *cmnd, int timeout, u32 *info)
 {
 	struct scsi_request *scp = scsi_allocate_request(sdev, GFP_KERNEL);
 	unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0;
@@ -727,8 +727,8 @@
 		complete(scp->request.waiting);
 }
 
-int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd,
-		 int timeout, u32 *info)
+static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd,
+			  char *cmnd, int timeout, u32 *info)
 {
 	Scsi_Cmnd *scp = scsi_allocate_device(sdev, 1, FALSE);
 	unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0;

[-mm patch] drivers/message/fusion/mptctl.c: make struct async_queue static

[Adrian Bunk]

On Tue, Feb 07, 2006 at 10:06:27PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc1-mm5:
>...
>  git-scsi-rc-fixes.patch
>...
>  Git trees
>...


There is no good reason for struct async_queue being global.

Additional, this patch adds some missing whitespace.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.16-rc2-mm1-full/drivers/message/fusion/mptctl.c.old	2006-02-10 00:43:43.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/drivers/message/fusion/mptctl.c	2006-02-10 00:43:59.000000000 +0100
@@ -140,7 +140,7 @@
  * Event Handler function
  */
 static int mptctl_event_process(MPT_ADAPTER *ioc, EventNotificationReply_t *pEvReply);
-struct fasync_struct *async_queue=NULL;
+static struct fasync_struct *async_queue = NULL;
 
 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
 /*

Re: [-mm patch] drivers/scsi/gdth.c: make __gdth_execute() static

[Christoph Hellwig]

On Fri, Feb 10, 2006 at 01:37:37AM +0100, Adrian Bunk wrote:
> I don't see any reason for __gdth_execute() being global.

Thanks, I've updated my patch locally and once I've gotten positive
testing feedback I'll send along the updated variant.

[-mm patch] drivers/message/fusion/mptctl.c: make struct async_queue static

[Adrian Bunk]

There is no good reason for struct async_queue being global.

Additional, this patch adds some missing whitespace.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 10 Feb 2006

--- linux-2.6.16-rc2-mm1-full/drivers/message/fusion/mptctl.c.old	2006-02-10 00:43:43.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/drivers/message/fusion/mptctl.c	2006-02-10 00:43:59.000000000 +0100
@@ -140,7 +140,7 @@
  * Event Handler function
  */
 static int mptctl_event_process(MPT_ADAPTER *ioc, EventNotificationReply_t *pEvReply);
-struct fasync_struct *async_queue=NULL;
+static struct fasync_struct *async_queue = NULL;
 
 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
 /*