Re: [Bugme-new] [Bug 6092] New: drivers/scsi/pcmcia/aha152x_stub.c: aha152x_resume(): variable used before set

[Andrew Morton <akpm@osdl.org>]

Jürgen E. Fischer <fischer@linux-buechse.de> wrote:
>
> Hi Andrew,
> 
> On Sat, Feb 18, 2006 at 14:14:23 -0800, Andrew Morton wrote:
> > >  Fix below.
>  
> > Thanks.
>  
> > Could we please have a more complete description of this change?  It's
> > obviosly doing more than fixing a used-uninitialised bug..
> 
> After fixing the problem in question, I discoved that the driver still
> didn't work with the pcmcia card I picked up.  run/is_complete was
> sometimes not called at all or called multiple times on one interrupt.
> 
> I'm not really sure why (or why that worked before).  It's now ensured
> that run() is only added to the task queue once per interrupt (by
> protecting 'service' with spinlocks).
> 
> Additionally interrupt sharing didn't seem to work as the interrupt
> handler didn't check if a interrupt condition was at all pending.
> 

So are you saying that with this patch, the driver works OK?

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html