[PATCH] Export spi_populate_* functions

[PATCH] Export spi_populate_* functions

[Matthew Wilcox]

These functions should be usable by modules.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>

diff -u ./drivers/scsi/scsi_transport_spi.c ./drivers/scsi/scsi_transport_spi.c
--- ./drivers/scsi/scsi_transport_spi.c	7 Feb 2006 13:11:26 -0000
+++ ./drivers/scsi/scsi_transport_spi.c	27 Feb 2006 14:13:18 -0000
@@ -1062,6 +1061,7 @@
 	msg[3] = width;
 	return 4;
 }
+EXPORT_SYMBOL(spi_populate_width_msg);
 
 int spi_populate_sync_msg(unsigned char *msg, int period, int offset)
 {
@@ -1072,6 +1072,7 @@
 	msg[4] = offset;
 	return 5;
 }
+EXPORT_SYMBOL(spi_populate_sync_msg);
 
 int spi_populate_ppr_msg(unsigned char *msg, int period, int offset,
 		int width, int options)
@@ -1086,6 +1087,7 @@
 	msg[7] = options;
 	return 8;
 }
+EXPORT_SYMBOL(spi_populate_ppr_msg);
 
 #ifdef CONFIG_SCSI_CONSTANTS
 static const char * const one_byte_msgs[] = {

Re: [PATCH] Export spi_populate_* functions

[Arjan van de Ven]

On Mon, 2006-02-27 at 07:18 -0700, Matthew Wilcox wrote:
> These functions should be usable by modules.


since this is new and very much linux specific code, shouldn't these be
_GPL exports?

Re: [PATCH] Export spi_populate_* functions

[James Bottomley]

On Mon, 2006-02-27 at 15:31 +0100, Arjan van de Ven wrote:
> since this is new and very much linux specific code, shouldn't these be
> _GPL exports?

Actually, try this commit:

http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=e855d0f4b3d4c421d4de5f30582e3aa579184adb

It's been there since I put the patch in ... otherwise none of my
modules would build ...

James

Re: [PATCH] Export spi_populate_* functions

[Matthew Wilcox]

On Mon, Feb 27, 2006 at 03:31:38PM +0100, Arjan van de Ven wrote:
> On Mon, 2006-02-27 at 07:18 -0700, Matthew Wilcox wrote:
> > These functions should be usable by modules.
> 
> since this is new and very much linux specific code, shouldn't these be
> _GPL exports?

how is it very much linux specific?  these  functions take a char
pointer and fill in that buffer with the messages defined in the scsi
specs.  there's no linux data structures used.

http://git.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=blobdiff;h=c0051a432a97d1f9181229aff0fc9484df10c342;hp=97f4be62f748af9791d1a1932244ea604a1432e7;hb=49db0bbd2a3648b1da8dee31f803fc52a06c57e1;f=drivers/scsi/scsi_transport_spi.c

Re: [PATCH] Export spi_populate_* functions

[Matthew Wilcox]

On Mon, Feb 27, 2006 at 08:47:42AM -0600, James Bottomley wrote:
> On Mon, 2006-02-27 at 15:31 +0100, Arjan van de Ven wrote:
> > since this is new and very much linux specific code, shouldn't these be
> > _GPL exports?
> 
> Actually, try this commit:
> 
> http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=e855d0f4b3d4c421d4de5f30582e3aa579184adb
> 
> It's been there since I put the patch in ... otherwise none of my
> modules would build ...

How  strange; when I looked  on  gitweb an hour  ago,  it  wasn't
there,  yet  now it  is.