From: Jeff Garzik <jgarzik@redhat.com>
To: "Tarte, Robert" <Robert_Tarte@adaptec.com>
Cc: Matthew Wilcox <matthew@wil.cx>, Jeff Garzik <jgarzik@pobox.com>,
Mike Anderson <andmike@us.ibm.com>,
James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] aic94xx: driver assertion in non-x86 BIOS env
Date: Wed, 1 Mar 2006 16:39:03 -0500 [thread overview]
Message-ID: <20060301213903.GJ14884@devserv.devel.redhat.com> (raw)
In-Reply-To: <8C064C48AB104B428CBA524C342357CA34CFC5@aime2k05.adaptec.com>
On Wed, Mar 01, 2006 at 01:22:56PM -0800, Tarte, Robert wrote:
> > From: Matthew Wilcox [mailto:matthew@wil.cx]
> > You're saying that you do an 8-byte non-DMA write to an address
> > that's congruent to 4 mod 8? Based on briefly skimming the internal
> > documentation for zx1, I'd say you're invoking undefined behaviour.
> Thanks for the confirmation. Internal documentation for zx1? Where can
> I locate this? Thanks in advance.
Overall, I would say that -- for any arch, not just zx1 -- you need to
make sure your write[bwlq]() calls are always naturally aligned in the
given register space. Anything else invites problems.
It sounds like you are already on the right track, though, converting
non-aligned writeq() to write[bwl]...
Jeff
next prev parent reply other threads:[~2006-03-01 21:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 21:22 [PATCH] aic94xx: driver assertion in non-x86 BIOS env Tarte, Robert
2006-03-01 21:39 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-03-01 20:57 Tarte, Robert
2006-03-01 21:12 ` Matthew Wilcox
2006-03-01 21:25 ` James Bottomley
2006-03-02 14:45 ` James Bottomley
2006-02-22 21:24 Tarte, Robert
2006-02-22 21:36 ` James Bottomley
2006-03-01 20:22 ` Jeff Garzik
2006-02-17 2:36 Mike Anderson
2006-02-20 11:11 ` Jeff Garzik
2006-02-21 19:16 ` James Bottomley
2006-02-22 6:26 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301213903.GJ14884@devserv.devel.redhat.com \
--to=jgarzik@redhat.com \
--cc=James.Bottomley@SteelEye.com \
--cc=Robert_Tarte@adaptec.com \
--cc=andmike@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).