linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [SCSI] Fix missing prototypes by including <linux/interrupt.h>.
@ 2006-03-03 15:21 Ralf Baechle
  2006-03-03 15:25 ` Matthew Wilcox
  0 siblings, 1 reply; 4+ messages in thread
From: Ralf Baechle @ 2006-03-03 15:21 UTC (permalink / raw)
  To: linux-scsi

diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c
index fb53eea..cd06e69 100644
--- a/drivers/scsi/wd33c93.c
+++ b/drivers/scsi/wd33c93.c
@@ -78,6 +78,7 @@
 #include <linux/string.h>
 #include <linux/delay.h>
 #include <linux/init.h>
+#include <linux/interrupt.h>
 #include <linux/blkdev.h>
 #include <asm/irq.h>
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [SCSI] Fix missing prototypes by including <linux/interrupt.h>.
  2006-03-03 15:21 Ralf Baechle
@ 2006-03-03 15:25 ` Matthew Wilcox
  2006-03-03 17:02   ` Ralf Baechle
  0 siblings, 1 reply; 4+ messages in thread
From: Matthew Wilcox @ 2006-03-03 15:25 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: linux-scsi

On Fri, Mar 03, 2006 at 03:21:48PM +0000, Ralf Baechle wrote:
> diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c
> index fb53eea..cd06e69 100644
> --- a/drivers/scsi/wd33c93.c
> +++ b/drivers/scsi/wd33c93.c
> @@ -78,6 +78,7 @@
>  #include <linux/string.h>
>  #include <linux/delay.h>
>  #include <linux/init.h>
> +#include <linux/interrupt.h>
>  #include <linux/blkdev.h>
>  #include <asm/irq.h>

If you're adding linux/interrupt.h, you should probably remove the
asm/irq.h since it'll be pulled in through asm/hardirq.h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [SCSI] Fix missing prototypes by including <linux/interrupt.h>.
@ 2006-03-03 16:34 Ralf Baechle
  0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2006-03-03 16:34 UTC (permalink / raw)
  To: linux-scsi

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c
index fb53eea..d8a7260 100644
--- a/drivers/scsi/wd33c93.c
+++ b/drivers/scsi/wd33c93.c
@@ -78,8 +78,8 @@
 #include <linux/string.h>
 #include <linux/delay.h>
 #include <linux/init.h>
+#include <linux/interrupt.h>
 #include <linux/blkdev.h>
-#include <asm/irq.h>
 
 #include <scsi/scsi.h>
 #include <scsi/scsi_cmnd.h>

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [SCSI] Fix missing prototypes by including <linux/interrupt.h>.
  2006-03-03 15:25 ` Matthew Wilcox
@ 2006-03-03 17:02   ` Ralf Baechle
  0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2006-03-03 17:02 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: linux-scsi

On Fri, Mar 03, 2006 at 08:25:06AM -0700, Matthew Wilcox wrote:

> If you're adding linux/interrupt.h, you should probably remove the
> asm/irq.h since it'll be pulled in through asm/hardirq.h

Indeed.  Resending in separate mail.

  Ralf

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-03-03 17:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-03 16:34 [SCSI] Fix missing prototypes by including <linux/interrupt.h> Ralf Baechle
  -- strict thread matches above, loose matches on Subject: below --
2006-03-03 15:21 Ralf Baechle
2006-03-03 15:25 ` Matthew Wilcox
2006-03-03 17:02   ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).