linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC: -mm patch] remove drivers/message/fusion/mptscsih.c:mptscsih_setDevicePage1Flags()
       [not found] <20060312031036.3a382581.akpm@osdl.org>
@ 2006-03-13 21:16 ` Adrian Bunk
  2006-03-13 21:21 ` [RFC: -mm patch] remove drivers/scsi/constants.c:scsi_print_req_sense() Adrian Bunk
  1 sibling, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-03-13 21:16 UTC (permalink / raw)
  To: Andrew Morton, support; +Cc: linux-kernel, mpt_linux_developer, linux-scsi

On Sun, Mar 12, 2006 at 03:10:36AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc5-mm3:
>...
>  git-scsi-misc.patch
>...
>  git trees
>...


This function no longer has any user.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/message/fusion/mptscsih.c |   49 ------------------------------
 1 file changed, 49 deletions(-)

--- linux-2.6.16-rc6-mm1-full/drivers/message/fusion/mptscsih.c.old	2006-03-13 21:28:56.000000000 +0100
+++ linux-2.6.16-rc6-mm1-full/drivers/message/fusion/mptscsih.c	2006-03-13 21:29:10.000000000 +0100
@@ -2783,55 +2783,6 @@
 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
 
 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
-/*
- *  SCSI Config Page functionality ...
- */
-/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
-/*	mptscsih_setDevicePage1Flags  - add Requested and Configuration fields flags
- *	based on width, factor and offset parameters.
- *	@width: bus width
- *	@factor: sync factor
- *	@offset: sync offset
- *	@requestedPtr: pointer to requested values (updated)
- *	@configurationPtr: pointer to configuration values (updated)
- *	@flags: flags to block WDTR or SDTR negotiation
- *
- *	Return: None.
- *
- *	Remark: Called by writeSDP1 and _dv_params
- */
-static void
-mptscsih_setDevicePage1Flags (u8 width, u8 factor, u8 offset, int *requestedPtr, int *configurationPtr, u8 flags)
-{
-	u8 nowide = flags & MPT_TARGET_NO_NEGO_WIDE;
-	u8 nosync = flags & MPT_TARGET_NO_NEGO_SYNC;
-
-	*configurationPtr = 0;
-	*requestedPtr = width ? MPI_SCSIDEVPAGE1_RP_WIDE : 0;
-	*requestedPtr |= (offset << 16) | (factor << 8);
-
-	if (width && offset && !nowide && !nosync) {
-		if (factor < MPT_ULTRA160) {
-			*requestedPtr |= (MPI_SCSIDEVPAGE1_RP_IU + MPI_SCSIDEVPAGE1_RP_DT);
-			if ((flags & MPT_TARGET_NO_NEGO_QAS) == 0)
-				*requestedPtr |= MPI_SCSIDEVPAGE1_RP_QAS;
-			if (flags & MPT_TAPE_NEGO_IDP)
-				*requestedPtr |= 0x08000000;
-		} else if (factor < MPT_ULTRA2) {
-			*requestedPtr |= MPI_SCSIDEVPAGE1_RP_DT;
-		}
-	}
-
-	if (nowide)
-		*configurationPtr |= MPI_SCSIDEVPAGE1_CONF_WDTR_DISALLOWED;
-
-	if (nosync)
-		*configurationPtr |= MPI_SCSIDEVPAGE1_CONF_SDTR_DISALLOWED;
-
-	return;
-}
-
-/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
 /*	mptscsih_writeIOCPage4  - write IOC Page 4
  *	@hd: Pointer to a SCSI Host Structure
  *	@target_id: write IOC Page4 for this ID & Bus


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC: -mm patch] remove drivers/scsi/constants.c:scsi_print_req_sense()
       [not found] <20060312031036.3a382581.akpm@osdl.org>
  2006-03-13 21:16 ` [RFC: -mm patch] remove drivers/message/fusion/mptscsih.c:mptscsih_setDevicePage1Flags() Adrian Bunk
@ 2006-03-13 21:21 ` Adrian Bunk
  1 sibling, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-03-13 21:21 UTC (permalink / raw)
  To: Andrew Morton, James.Bottomley; +Cc: linux-kernel, linux-scsi

On Sun, Mar 12, 2006 at 03:10:36AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc5-mm3:
>...
>  git-scsi-misc.patch
>...
>  git trees
>...


This function is no longer used anywhere.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/scsi/constants.c |   10 ----------
 include/scsi/scsi_dbg.h  |    1 -
 2 files changed, 11 deletions(-)

--- linux-2.6.16-rc6-mm1-full/include/scsi/scsi_dbg.h.old	2006-03-13 21:15:08.000000000 +0100
+++ linux-2.6.16-rc6-mm1-full/include/scsi/scsi_dbg.h	2006-03-13 21:15:17.000000000 +0100
@@ -9,7 +9,6 @@
 extern void scsi_print_sense_hdr(const char *, struct scsi_sense_hdr *);
 extern void __scsi_print_command(unsigned char *);
 extern void scsi_print_sense(const char *, struct scsi_cmnd *);
-extern void scsi_print_req_sense(const char *, struct scsi_request *);
 extern void __scsi_print_sense(const char *name,
 			       const unsigned char *sense_buffer,
 			       int sense_len);
--- linux-2.6.16-rc6-mm1-full/drivers/scsi/constants.c.old	2006-03-13 21:15:41.000000000 +0100
+++ linux-2.6.16-rc6-mm1-full/drivers/scsi/constants.c	2006-03-13 21:39:51.000000000 +0100
@@ -1259,16 +1259,6 @@
 }
 EXPORT_SYMBOL(scsi_print_sense);
 
-void scsi_print_req_sense(const char *devclass, struct scsi_request *sreq)
-{
-	const char *name = devclass;
-
-	if (sreq->sr_request->rq_disk)
-		name = sreq->sr_request->rq_disk->disk_name;
-	__scsi_print_sense(name, sreq->sr_sense_buffer, SCSI_SENSE_BUFFERSIZE);
-}
-EXPORT_SYMBOL(scsi_print_req_sense);
-
 void scsi_print_command(struct scsi_cmnd *cmd)
 {
 	/* Assume appended output (i.e. not at start of line) */


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-03-13 21:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20060312031036.3a382581.akpm@osdl.org>
2006-03-13 21:16 ` [RFC: -mm patch] remove drivers/message/fusion/mptscsih.c:mptscsih_setDevicePage1Flags() Adrian Bunk
2006-03-13 21:21 ` [RFC: -mm patch] remove drivers/scsi/constants.c:scsi_print_req_sense() Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).