Re: section mismatches (scsi e.g.)

["Randy.Dunlap" <rdunlap@xenotime.net>]

On Fri, 14 Apr 2006 18:52:10 +0200 Sam Ravnborg wrote:

> On Fri, Apr 14, 2006 at 09:29:11AM -0700, Randy.Dunlap wrote:
> > Hi Sam,
> > 
> > I was looking at these warnings (on 2.6.17-rc1-git8):
> > 
> > WARNING: drivers/scsi/3w-9xxx.o - Section mismatch: reference to .init.data: from .data between 'twa_driver' (at offset 0x18) and 'twa_error_table'
> > WARNING: drivers/scsi/3w-xxxx.o - Section mismatch: reference to .init.data: from .data between 'tw_driver' (at offset 0x18) and 'tw_sense_table'
> > WARNING: drivers/scsi/gdth.o - Section mismatch: reference to .init.text:gdth_detect from .data between 'driver_template' (at offset 0x270) and 'async_cache_tab'
> > 
> > I either don't see a problem or I'm having trouble reading/decoding
> > the warning messages.  Could you look at these 3 sometime?
> 
> > WARNING: drivers/scsi/3w-9xxx.o
> twa_driver contains a reference to twa_pci_tbl which is marked
> devinitdata.
> 
> Darren Jenkins already pointed this pattern out but somehow I lost
> the patch (not applied).
> It is here:

[snip]

> > WARNING: drivers/scsi/gdth.o 
> >From modpost.c:
> * Pattern 2:
> *   Many drivers utilise a *_driver container with references to
> *   add, remove, probe functions etc.
> *   These functions may often be marked __init and we do not want to
> *   warn here.
> *   the pattern is identified by:
> *   tosec   = .init.text | .exit.text
> *   fromsec = .data
> *   atsym = *_driver, *_ops, *_probe, *probe_one
> **/
> 
> Shall we include *_template in this list?

I would say yes.

> The most common name seems to be the ambigous driver_template.
> Some scsi drievers has been a bit more specific and used
> <driver>_template.
> In total 76 drivers.
> 
> 16 drivers uses: *_sht for their scsi_host_template variables.
> And one uses NCR_Q720_tpnt.
> 
> I will push the 'lost' patch later today.

+ I don't see the inconsistencies that James mentioned.

Thanks.

---
~Randy