From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: request to add aic94xx to -mm
Date: Fri, 28 Apr 2006 18:58:26 +0100 [thread overview]
Message-ID: <20060428175826.GA18373@infradead.org> (raw)
In-Reply-To: <1146243246.5251.29.camel@mulgrave.il.steeleye.com>
more comments on the actual aic94xx driver:
- the README file wouldn't contain much anymore after the outdated
bits are removed, I'd suggest killing it and listing the supported
hardware in the Kconfig instead
- lots of inline abuse that should go away
- please use the pci_iomap api to support pio and mmio transparently
instead of the local wrappers
- no need to handle signle-element SG lists anymore
- CLEAR_NEXUS_PRE and CLEAR_NEXUS_POST should become real functions instead
of context-sensitive macros
- what about replacing ASD_DPRINTK with the standard debugging helpers?
prev parent reply other threads:[~2006-04-28 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 16:54 request to add aic94xx to -mm James Bottomley
2006-04-28 17:16 ` Douglas Gilbert
2006-04-28 17:31 ` Mike Anderson
2006-04-28 17:31 ` James Bottomley
2006-04-28 17:27 ` Christoph Hellwig
2006-04-28 17:55 ` Mike Anderson
2006-04-28 17:59 ` Christoph Hellwig
2006-05-02 7:10 ` Hannes Reinecke
2006-04-28 18:02 ` Arjan van de Ven
2006-04-28 17:46 ` Christoph Hellwig
2006-05-02 15:07 ` Jeff Garzik
2006-05-03 14:02 ` James Bottomley
2006-04-28 17:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060428175826.GA18373@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox