public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Kurt Garloff <garloff@suse.de>
To: Linux SCSI list <linux-scsi@vger.kernel.org>
Cc: Patrick Mansfield <patmans@us.ibm.com>, Andrew Morton <akpm@osdl.org>
Subject: [PATCH 0/3] Resend: Handle PQ3 devs better
Date: Mon, 1 May 2006 02:44:57 +0200	[thread overview]
Message-ID: <20060501004457.GC8728@tpkurt.garloff.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]

Hi,

resending the patches ...
Changes since last posting:
- I reversed the order of patches 2 and 3, as one patch (now 3)
  refers to a blacklist flag introduced in the other.
- Andrew Morton has merged the patches into -mm and fixed up compiler
  warnings that happened if CONFIG_SCSI_LOGGING was disabled.
  I merged that into patch 3.
- The blist flag 0x800000 has been consumed by BLIST_MAX_512, so
  go for 0x1000000 instead.

Description of the patchset:

The trouble is that there are devices that report a LUN with
peripheral qualifier 3 on LUN0.
We currently don't handle this well yet:
- Blacklist flags are not used to do special handling if needed.
- If the device does NOT support the REPORT_LUNS scan, we won't
  see any LUN at all, as we don't even look for LUN 1 then.

Yes, such devices do exist, actually, see PATCH2 ..

The patches do:
- Unconditionally at least look for LUN 1 if LUN 0 was a PQ3
  device (but abort scanning there is SPARSELUN is not set
  and no device can be attached to LUN 1)
- Return the blacklist flags for further usage even if LUN 0
  was a PQ3 device.
- Introduce a blacklist flag BLIST_ATTACH_PQ3 that allows
  a PQ3 device to be registered with the OS and thus sg can
  attach to it. Add two devices to the list.
  (One could argue that this should be default, but who knows
   what virtual scsi driver will break then ...)
- Improve the scsi logging information for the the user about
  the PQ3 issue.

Patches are agains 2.6.17rc3, please consider merging for 2.6.17/18.

Best,
-- 
Kurt Garloff, Head Architect Linux R&D, Novell Inc.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2006-05-01  0:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-01  0:44 Kurt Garloff [this message]
2006-05-01  0:48 ` [PATCH 1/3] Continue after PQ3 on LUN0 Kurt Garloff
2006-05-01  0:49 ` [PATCH 2/3] BLIST_ATTACH_PQ3 flag Kurt Garloff
2006-05-01  0:50 ` [PATCH 3/3] Print warning for PQ3 devs Kurt Garloff
2006-05-01  1:04 ` [PATCH 0/3] Resend: Handle PQ3 devs better James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060501004457.GC8728@tpkurt.garloff.de \
    --to=garloff@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=patmans@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox