Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache

Erik Mouw
2006-05-24T14:07:41Z

On Fri, May 12, 2006 at 04:50:32PM -0700, Linus Torvalds wrote:
> On Sat, 13 May 2006, Al Viro wrote:
> >
> > BTW, the best option is to kill bdev_uevent() again. Short of that,
> > skip PHYSDEV mess if disk doesn't have GENHD_FL_UP.
>
> I do think the mount/umount events are valid and interesting, so I'd much
> rather see the second version.
>
> However, that does beg the question: wouldn't that effectively be what the
> patch I posted would do? Notably the "disk->driverfs_dev = NULL" part
> after we've dropped it (the "KOBJ_REMOVE" event move is a separate issue,
> mixed here into the same patch, but should result in possibly better name
> generation for the event).
>
> Basically, onces driverfs_dev has been dropped, we NULL it out, and then
> the people who use it automatically get the right result.
>
> Yes? No? "You're a total klutz, Linus, that patch won't actually do
> anything, because <xyz>"?

Just want to confirm that I can't recreate the SCSI slab error anymore
with your patch (032ebf2620ef99a4fedaa0f77dc2272095ac5863) in the
current -git kernel.

Erik

--
+-- Erik Mouw -- www.harddisk-recovery.nl -- +31 70 370 12 90 --
| Lab address: Delftechpark 26, 2628 XH, Delft, The Netherlands