From: Matthew Wilcox <matthew@wil.cx>
To: Amit Arora <aarora@in.ibm.com>
Cc: linux-scsi@vger.kernel.org, patmans@us.ibm.com
Subject: Re: [PATCH] scsi: Return -EINVAL when "id == max_id" in scsi_scan_host_selected()
Date: Fri, 19 May 2006 22:21:32 -0600 [thread overview]
Message-ID: <20060520042132.GC2826@parisc-linux.org> (raw)
In-Reply-To: <1148080489.23417.18.camel@amitarora.in.ibm.com>
On Fri, May 19, 2006 at 04:14:50PM -0700, Amit Arora wrote:
> The scsi_scan_host_selected() should return -EINVAL when the id is equal
> to the max_id. Currently it uses ">" when comparing with max_id, and
> hence leaves the border case when "id==max_id".
> The channel and lun have values valid from 0 up to,
> and including, max_channel or max_lun. But, the valid values for id
> range from 0 to max_id-1. This patch fixes the problem.
You're right, but the patch is wrong. It's not acceptable to have
different meanings for variables with such similar names. Either it
needs to be renamed to id_count or we need to fix all the other users of
max_id.
BTW, I think we have another problem with max_lun:
max_dev_lun = min(max_scsi_luns, shost->max_lun);
...
for (lun = 1; lun < max_dev_lun; ++lun)
surely that should be <= ?
next prev parent reply other threads:[~2006-05-20 4:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-19 23:14 [PATCH] scsi: Return -EINVAL when "id == max_id" in scsi_scan_host_selected() Amit Arora
2006-05-20 4:21 ` Matthew Wilcox [this message]
2006-05-20 19:41 ` Amit Arora
2006-05-21 3:34 ` Luben Tuikov
2006-05-21 4:05 ` Matthew Wilcox
2006-05-22 19:01 ` Amit Arora
2006-05-23 0:54 ` James Bottomley
2006-05-23 1:16 ` Matthew Wilcox
2006-05-23 7:47 ` Hannes Reinecke
2006-05-23 8:29 ` Hannes Reinecke
2006-05-26 23:50 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060520042132.GC2826@parisc-linux.org \
--to=matthew@wil.cx \
--cc=aarora@in.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox